Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade cosmovisor & ics23 #12645

Merged
merged 12 commits into from
Jul 21, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jul 19, 2022

Description

  • feat: Go Workspace #11453 exposes all the technical debt
  • This PR does version bumps on cosmovisor to make it easier to use go workspaces in the cosmos-sdk.
  • Upgrades cosmovisor to sdk v0.46.0-rc3
  • Upgrades ics23 to main branch of cosmos-sdk
  • As a side-effect, upgrades tendermint for the sdk to v0.35.8

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat faddat requested a review from a team as a code owner July 19, 2022 23:34
@github-actions github-actions bot added C:Cosmovisor Issues and PR related to Cosmovisor C:Store labels Jul 19, 2022
@faddat faddat changed the title Upgrade cosmovisor and get rid of gogo/protobuf v1.3.3 chore: Upgrade cosmovisor and get rid of gogo/protobuf v1.3.3 Jul 19, 2022
@faddat faddat changed the title chore: Upgrade cosmovisor and get rid of gogo/protobuf v1.3.3 chore: Upgrade cosmovisor & ics23 and get rid of gogo/protobuf v1.3.3 Jul 19, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
faddat and others added 2 commits July 20, 2022 06:53
Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't change anything with gogo/protobuf. Let's update the title before merging otherwise it's missleading.

FYI: there is still an issue in the gogo -> cosmos gogo migration

@faddat
Copy link
Contributor Author

faddat commented Jul 20, 2022

Correct.

This PR and #12596 are aimed at changing the import version, but not the replace, because then, go work sync works properly.

@faddat faddat changed the title chore: Upgrade cosmovisor & ics23 and get rid of gogo/protobuf v1.3.3 chore: Upgrade cosmovisor & ics23 Jul 20, 2022
@faddat
Copy link
Contributor Author

faddat commented Jul 20, 2022

@robert-zaremba you're right though, which is sort of wierd..... (not weird that youre right: weird that I could have sworn this dealt with gogo/protobufs versions. Anyhow, this will still help #11453 get over the line)

Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating the title

@faddat
Copy link
Contributor Author

faddat commented Jul 20, 2022

Basically the changes are aimed at making sure that these lines:

github.com/gogo/protobuf v1.3.2 // indirect

Remain importing v1.3.2

Then I will probably just fully redo the workspaces PR.

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #12645 (dbd5284) into main (a5d5461) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12645      +/-   ##
==========================================
+ Coverage   65.14%   65.17%   +0.02%     
==========================================
  Files         693      693              
  Lines       70805    70805              
==========================================
+ Hits        46128    46145      +17     
+ Misses      22106    22089      -17     
  Partials     2571     2571              
Impacted Files Coverage Δ
x/group/keeper/keeper.go 58.26% <0.00%> (-0.40%) ⬇️
x/distribution/simulation/operations.go 90.42% <0.00%> (+9.57%) ⬆️

@faddat faddat mentioned this pull request Jul 21, 2022
19 tasks
@tac0turtle tac0turtle merged commit d94001c into cosmos:main Jul 21, 2022
@faddat faddat mentioned this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Cosmovisor Issues and PR related to Cosmovisor C:Store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants