-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade cosmovisor & ics23 #12645
Conversation
use correct sdk path
Co-authored-by: Julien Robert <julien@rbrt.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR doesn't change anything with gogo/protobuf. Let's update the title before merging otherwise it's missleading.
FYI: there is still an issue in the gogo -> cosmos gogo migration
Correct. This PR and #12596 are aimed at changing the import version, but not the replace, because then, |
@robert-zaremba you're right though, which is sort of wierd..... (not weird that youre right: weird that I could have sworn this dealt with gogo/protobufs versions. Anyhow, this will still help #11453 get over the line) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for updating the title
Basically the changes are aimed at making sure that these lines: Line 55 in 6ad9246
Remain importing v1.3.2 Then I will probably just fully redo the workspaces PR. |
Codecov Report
@@ Coverage Diff @@
## main #12645 +/- ##
==========================================
+ Coverage 65.14% 65.17% +0.02%
==========================================
Files 693 693
Lines 70805 70805
==========================================
+ Hits 46128 46145 +17
+ Misses 22106 22089 -17
Partials 2571 2571
|
Description
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change