Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate usage of types/store.go to store/types/.. #14406

Closed
2 tasks
tac0turtle opened this issue Dec 23, 2022 · 1 comment · Fixed by #14455
Closed
2 tasks

migrate usage of types/store.go to store/types/.. #14406

tac0turtle opened this issue Dec 23, 2022 · 1 comment · Fixed by #14455
Assignees
@noelukwa
Labels
C:Store good first issue T:tech debt Tech debt that should be cleaned up

Comments

@tac0turtle
Copy link
Member

Summary

The types/store.go file aliases many store types to be used throughout the repo, we should migrate all these calls to the unaliased version.

At the end of this issue we should be able to remove types/store.go file

Work

  • Migrate all calls to types/store.go to store/types.
  • Remove alias file in types package
@tac0turtle tac0turtle added good first issue C:Store T:tech debt Tech debt that should be cleaned up labels Dec 23, 2022
@noelukwa
Copy link
Contributor

noelukwa commented Dec 25, 2022 •
edited
Loading

I would like to work on this @tac0turtle .

This was referenced Dec 30, 2022
Closed
Closed
Merged
tac0turtle pushed a commit that referenced this issue Jan 10, 2023
@noelukwa
refactor: migrate calls from alias file to appropriate store/types (#…
c822836 
…14455)

Co-authored-by: Marko <marbar3778@yahoo.com>
Closes #14406
0xmuralik pushed a commit to 0xmuralik/cosmos-sdk that referenced this issue Jan 12, 2023
@noelukwa @0xmuralik
refactor: migrate calls from alias file to appropriate store/types (c…
b44a871 
…osmos#14455)

Co-authored-by: Marko <marbar3778@yahoo.com>
Closes cosmos#14406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noelukwa noelukwa

Labels
C:Store good first issue T:tech debt Tech debt that should be cleaned up
Projects
None yet
Milestone
No milestone
2 participants
@noelukwa @tac0turtle