Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate calls from alias file to store/types/ #14450

Closed
wants to merge 18 commits into from
Closed

refactor: migrate calls from alias file to store/types/ #14450

wants to merge 18 commits into from

Conversation

noelukwa
Copy link
Contributor

Description

Migrates calls to alias file in types/store.go to store/types module

Closes: #14406

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

noelukwa and others added 16 commits December 30, 2022 08:28
@noelukwa
refactor : replace calls to types/store with store/types
bce20ad
@julienrbrt @noelukwa
fix: fix race conditions from #14332 (#14402)
fd90028
@tac0turtle @noelukwa
refactor: add title, summary and proposer to proposal struct of gov (#…
a82cea6 
…14390)
@faddat @noelukwa
chore: longer golang-ci timeout (#14432)
0d6d3ce
@tac0turtle @noelukwa
refactor: remove base app from store (#14417)
814adda 
This pr removes base app from the store package. This is un order to decouple store from the sdk. There are a few things we can clean up but the telemetry package may be difficult with how it's done.

---

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
@tac0turtle @noelukwa
chore: remove unused code from server (#14437)
027ce55
@dangush @tac0turtle
@alexanderbez @noelukwa
docs: Spec on current cachekv implementation (#13977)
6ebab2f 
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Marko <marko@baricevic.me>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@tac0turtle @noelukwa
refactor: pass logger to store (#14438)
f45f5b5
@catShaark @tac0turtle @noelukwa
chore: Enforce order of store commits in root store (#14385)
cae2bb7 
Co-authored-by: Marko <marbar3778@yahoo.com>
@faddat @tac0turtle @noelukwa
chore: iavl-v0.20-alpha1 and cosmos-db (#14411)
f50d42f 
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
@julienrbrt @noelukwa
chore: fix replaces (#14440)
45fb11b
@0Tech @noelukwa
chore: loosen assertions in SetOrderBeginBlockers() and SetOrderEndBl…
1c1994d 
…ockers() (#14415)
@julienrbrt @noelukwa
fix: fix --log_format flag not working (#14441)
caf5b29
@dependabot @noelukwa
build(deps): Bump github.com/mattn/go-isatty from 0.0.16 to 0.0.17 (#…
fdca1f6 
…14445)
@noelukwa
refactor : migrate calls from alias file to store/types/
b9b659f
@noelukwa
fix : merge conflicts
55e005b
@noelukwa noelukwa changed the title refactor : migrate calls from alias file to store/types/ refactor: migrate calls from alias file to store/types/ Dec 30, 2022
@noelukwa noelukwa closed this Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facundomedica facundomedica Awaiting requested review from facundomedica facundomedica will be requested when the pull request is marked ready for review facundomedica is a code owner

@cool-develope cool-develope Awaiting requested review from cool-develope cool-develope will be requested when the pull request is marked ready for review cool-develope is a code owner

@akhilkumarpilli akhilkumarpilli Awaiting requested review from akhilkumarpilli akhilkumarpilli will be requested when the pull request is marked ready for review akhilkumarpilli is a code owner

@lucaslopezf lucaslopezf Awaiting requested review from lucaslopezf lucaslopezf will be requested when the pull request is marked ready for review lucaslopezf is a code owner

@testinginprod testinginprod Awaiting requested review from testinginprod testinginprod will be requested when the pull request is marked ready for review testinginprod is a code owner

@JulianToledano JulianToledano Awaiting requested review from JulianToledano JulianToledano will be requested when the pull request is marked ready for review JulianToledano is a code owner

@ziscky ziscky Awaiting requested review from ziscky ziscky will be requested when the pull request is marked ready for review ziscky is a code owner

@raynaudoe raynaudoe Awaiting requested review from raynaudoe raynaudoe will be requested when the pull request is marked ready for review raynaudoe is a code owner

@alpe alpe Awaiting requested review from alpe alpe will be requested when the pull request is marked ready for review alpe is a code owner

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski will be requested when the pull request is marked ready for review kocubinski is a code owner

@julienrbrt julienrbrt Awaiting requested review from julienrbrt julienrbrt will be requested when the pull request is marked ready for review julienrbrt is a code owner

@sontrinh16 sontrinh16 Awaiting requested review from sontrinh16 sontrinh16 will be requested when the pull request is marked ready for review sontrinh16 is a code owner

@hieuvubk hieuvubk Awaiting requested review from hieuvubk hieuvubk will be requested when the pull request is marked ready for review hieuvubk is a code owner

@aaronc aaronc Awaiting requested review from aaronc aaronc will be requested when the pull request is marked ready for review aaronc is a code owner

Assignees
No one assigned
Labels
C:Store C:x/auth C:x/authz C:x/bank C:x/capability C:x/consensus C:x/crisis C:x/distribution distribution module related C:x/evidence C:x/feegrant C:x/genutil genutil module issues C:x/gov C:x/group C:x/mint C:x/nft C:x/params C:x/slashing C:x/staking C:x/upgrade Type: ADR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate usage of types/store.go to store/types/..
7 participants
@noelukwa @julienrbrt @tac0turtle @faddat @dangush @catShaark @0Tech