Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[audit, nit]: client/v2/autocli/testdata/*.golden files have unnecessary trailing tabs and whitespace before end of line #17851

Closed
1 task done
odeke-em opened this issue Sep 25, 2023 · 1 comment · Fixed by #17852
Closed
1 task done

[audit, nit]: client/v2/autocli/testdata/*.golden files have unnecessary trailing tabs and whitespace before end of line #17851

odeke-em opened this issue Sep 25, 2023 · 1 comment · Fixed by #17852
Assignees
@odeke-em
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@odeke-em
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

This isn't a functionality problem but more of a nit but I have to raise it because it is in what are supposed to be golden files (the rubric for other generated code) per

$ git grep '\s\+$' | cut -d":" -f1 | sort | uniq
help-deprecated-msg.golden
help-deprecated.golden
help-echo-msg.golden
help-echo.golden
help.golden

and for example
Screenshot 2023-09-24 at 6 58 46 PM

Cosmos SDK Version

v0.50.0-rc.0

How to reproduce?

No response
@odeke-em odeke-em added the Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Sep 25, 2023
@odeke-em odeke-em self-assigned this Sep 25, 2023
odeke-em added a commit that referenced this issue Sep 25, 2023
@odeke-em
refactor: client/v2/autocli/testdata: remove trailing whitespace in .…
bc02db4 
…golden files

Found while auditing v0.50.0-beta0 vs v0.50.0-rc0. In the future, one
can verify absence by running

```shell
$ git grep '\s\+$' | cut -d":" -f1 | sort | uniq
```

Fixes #17851
@odeke-em odeke-em mentioned this issue Sep 25, 2023
Merged
@julienrbrt julienrbrt reopened this Sep 25, 2023
@julienrbrt
Copy link
Member

See #17858

@julienrbrt julienrbrt closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odeke-em odeke-em

Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(client/v2): remove trailing whitespace in golden files cosmos/cosmos-sdk
2 participants
@odeke-em @julienrbrt