Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client/v2): better method naming #17858

Merged
merged 2 commits into from
Sep 25, 2023
Merged

chore(client/v2): better method naming #17858

merged 2 commits into from
Sep 25, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Sep 25, 2023

Description

Closes: #17853

Reverts 35d93a9. The tests weren't run there because it did contain go code. The tests fail without those spaces, and running go test ./... -update re-adds them.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Sep 25, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner September 25, 2023 07:01
@github-actions github-actions bot added the C:CLI label Sep 25, 2023
Copy link
Collaborator

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @julienrbrt, LGTM!

@julienrbrt julienrbrt added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit 284c955 Sep 25, 2023
54 checks passed
@julienrbrt julienrbrt deleted the julien/nit-client branch September 25, 2023 08:39
mergify bot pushed a commit that referenced this pull request Sep 25, 2023
julienrbrt added a commit that referenced this pull request Sep 25, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[audit]: client/v2/autocli.Builder.Validate has unexpected side effects yet is just a validation function
3 participants