-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: install rocksdb in github actions #10470
Conversation
@roysc I'm receiving this errors, do you have an idea how to fix it?
|
Possible workaround will be to ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @robert-zaremba!
@robert-zaremba the RocksDB version will need to be at least 6.24 - this will probably need to be a source build for CI to work |
@@ -53,6 +53,8 @@ jobs: | |||
- uses: actions/setup-go@v2.1.4 | |||
with: | |||
go-version: 1.17 | |||
- name: install rocksdb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use a docker image? This will be run each time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating a docker to test one package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker would especially help with the source install
This works using a source build on #10479 (targets this PR branch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets use this docker image:
container: tendermintdev/docker-tm-db-testing
closing in favor of #10479 |
Description
Closes: #10472
/db/rocksdb
requires rocksdb-dev to download dependency and execute tests.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change