Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install rocksdb in github actions #10479

Merged
merged 8 commits into from
Nov 10, 2021
Merged

Conversation

roysc
Copy link
Contributor

@roysc roysc commented Nov 2, 2021

Builds and installs RocksDB from source for CI tests

Closes: #10472


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@roysc roysc changed the base branch from master to robert/ci-rocksdb-test November 4, 2021 06:32
@roysc roysc marked this pull request as ready for review November 4, 2021 06:32
@roysc roysc mentioned this pull request Nov 4, 2021
19 tasks
@roysc roysc force-pushed the ci-rocksdb branch 3 times, most recently from 9cfb500 to de2b3ff Compare November 9, 2021 13:02
@tac0turtle tac0turtle changed the base branch from robert/ci-rocksdb-test to master November 9, 2021 13:04
db/rocksdb/db.go Outdated Show resolved Hide resolved
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Nov 9, 2021
@tac0turtle
Copy link
Member

@roysc can you update to master, ill try to be active to merge this

@tac0turtle tac0turtle merged commit bb70dca into cosmos:master Nov 10, 2021
@roysc roysc deleted the ci-rocksdb branch November 10, 2021 10:36
blewater pushed a commit to e-money/cosmos-sdk that referenced this pull request Dec 8, 2021
* fix: install rocksdb in github actions

* install rocksdb 6.24.2 from source

* go mod tidy

* Run test-submodules on tm-db testing container

rather than install rocksdb

* cleanup

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T: CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix db/rocksdb build and CI
3 participants