-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: grpc-only mode #11430
feat: grpc-only mode #11430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. One nit comment to implicitly enable gRPC when grpc-only
is set.
@@ -96,6 +94,12 @@ will not be able to commit subsequent blocks. | |||
|
|||
For profiling and benchmarking purposes, CPU profiling can be enabled via the '--cpu-profile' flag | |||
which accepts a path for the resulting pprof file. | |||
|
|||
The node may be started in a 'query only' mode where only the gRPC and JSON HTTP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the queries from Tendermint supported in this mode? Stuff like block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is gRPC only mode. The doc and implementation states Tendermint is disabled (i.e. not started). Tendermint cannot be supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it sync new state though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because again, Tendermint is not running. This just serves existing data via gRPC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh yeah, thank you & sorry for the dumb question. 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No such thing :p
* updates * lint++ * updates * updates * updates * updates * cl++ * updates Co-authored-by: Marko <marbar3778@yahoo.com> (cherry picked from commit 1880a7d) # Conflicts: # CHANGELOG.md # server/start.go
Description
Closes: #10796
grpc-only
, which when enabled, starts the node with the gRPC and it's HTTP API variant only.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change