Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use module permission from app_config in app.go #12997

Merged
merged 12 commits into from
Aug 23, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Aug 22, 2022

Description

  • The app.go should use the permission from the app config instead of the map. This was a left-over from the legacy app.
  • As we are touching app_legacy.go this replicates fix: fix the gov proposals #13002 here in app_legacy.go
  • Improve blocked address test to actually check against blocked accounts (instead of the default module accounts with permissions)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner August 22, 2022 21:12
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #12997 (0c53198) into main (8372f54) will decrease coverage by 0.07%.
The diff coverage is 44.44%.

❗ Current head 0c53198 differs from pull request most recent head 4d72f18. Consider uploading reports for the commit 4d72f18 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12997      +/-   ##
==========================================
- Coverage   55.71%   55.64%   -0.08%     
==========================================
  Files         648      644       -4     
  Lines       54963    54861     -102     
==========================================
- Hits        30624    30525      -99     
- Misses      21868    21874       +6     
+ Partials     2471     2462       -9     
Impacted Files Coverage Δ
x/bank/module.go 60.78% <0.00%> (+0.59%) ⬆️
simapp/app.go 77.77% <50.00%> (-4.89%) ⬇️
x/distribution/simulation/operations.go 80.64% <0.00%> (-9.68%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️
tx/textual/valuerenderer/int.go
tx/textual/valuerenderer/valuerenderer.go
tx/textual/valuerenderer/bytes.go
tx/textual/valuerenderer/dec.go

@alexanderbez
Copy link
Contributor

I guess this supersedes my PR #13003 which I think we can close.

@alexanderbez alexanderbez mentioned this pull request Aug 23, 2022
19 tasks
@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 23, 2022
@julienrbrt julienrbrt merged commit 2e1fb48 into main Aug 23, 2022
@julienrbrt julienrbrt deleted the julien/app-wiring-acc-perms branch August 23, 2022 16:21
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/bank
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants