Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use module permission from app_config in app.go #12997

Merged
merged 12 commits into from
Aug 23, 2022
Merged

fix: use module permission from app_config in app.go #12997

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ef07858
fix: use module permission from app_config in `app.go`
julienrbrt Aug 22, 2022
d4980c7
fix build
julienrbrt Aug 22, 2022
ca647fe
fix name conflict
julienrbrt Aug 22, 2022
604ae3f
Merge branch 'main' into julien/app-wiring-acc-perms
julienrbrt Aug 22, 2022
e9b68b2
Merge branch 'main' into julien/app-wiring-acc-perms
julienrbrt Aug 23, 2022
fb731fc
fix test
julienrbrt Aug 23, 2022
98acaa3
make lint-fix
julienrbrt Aug 23, 2022
5133576
add comments
julienrbrt Aug 23, 2022
0d76b22
Merge branch 'main' into julien/app-wiring-acc-perms
alexanderbez Aug 23, 2022
233f2e4
fix upgrade keeper location (ref #13002)
julienrbrt Aug 23, 2022
0c53198
Merge branch 'main' into julien/app-wiring-acc-perms
alexanderbez Aug 23, 2022
4d72f18
Merge branch 'main' into julien/app-wiring-acc-perms
julienrbrt Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions simapp/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,17 +121,6 @@ var (
vesting.AppModuleBasic{},
nftmodule.AppModuleBasic{},
)

// module account permissions
maccPerms = map[string][]string{
authtypes.FeeCollectorName: nil,
distrtypes.ModuleName: nil,
minttypes.ModuleName: {authtypes.Minter},
stakingtypes.BondedPoolName: {authtypes.Burner, authtypes.Staking},
stakingtypes.NotBondedPoolName: {authtypes.Burner, authtypes.Staking},
govtypes.ModuleName: {authtypes.Burner},
nft.ModuleName: nil,
}
)

var (
Expand Down Expand Up @@ -387,9 +376,10 @@ func (app *SimApp) RegisterAPIRoutes(apiSvr *api.Server, apiConfig config.APICon

// GetMaccPerms returns a copy of the module account permissions
func GetMaccPerms() map[string][]string {
dupMaccPerms := make(map[string][]string)
for k, v := range maccPerms {
dupMaccPerms[k] = v
dup := make(map[string][]string)
for _, perms := range moduleAccPerms {
dup[perms.Account] = perms.Permissions
}
return dupMaccPerms

return dup
}
24 changes: 13 additions & 11 deletions simapp/app_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,16 +112,8 @@ var AppConfig = appconfig.Compose(&appv1alpha1.Config{
{
Name: authtypes.ModuleName,
Config: appconfig.WrapAny(&authmodulev1.Module{
Bech32Prefix: "cosmos",
ModuleAccountPermissions: []*authmodulev1.ModuleAccountPermission{
{Account: authtypes.FeeCollectorName},
{Account: distrtypes.ModuleName},
{Account: minttypes.ModuleName, Permissions: []string{authtypes.Minter}},
{Account: stakingtypes.BondedPoolName, Permissions: []string{authtypes.Burner, stakingtypes.ModuleName}},
{Account: stakingtypes.NotBondedPoolName, Permissions: []string{authtypes.Burner, stakingtypes.ModuleName}},
{Account: govtypes.ModuleName, Permissions: []string{authtypes.Burner}},
{Account: nft.ModuleName},
},
Bech32Prefix: "cosmos",
ModuleAccountPermissions: moduleAccPerms,
}),
},
{
Expand All @@ -137,7 +129,6 @@ var AppConfig = appconfig.Compose(&appv1alpha1.Config{
minttypes.ModuleName,
stakingtypes.BondedPoolName,
stakingtypes.NotBondedPoolName,
govtypes.ModuleName,
julienrbrt marked this conversation as resolved.
Show resolved Hide resolved
nft.ModuleName,
// We allow the following module accounts to receive funds:
// govtypes.ModuleName
Expand Down Expand Up @@ -215,3 +206,14 @@ var AppConfig = appconfig.Compose(&appv1alpha1.Config{
},
},
})

// module account permissions
var moduleAccPerms = []*authmodulev1.ModuleAccountPermission{
{Account: authtypes.FeeCollectorName},
{Account: distrtypes.ModuleName},
{Account: minttypes.ModuleName, Permissions: []string{authtypes.Minter}},
{Account: stakingtypes.BondedPoolName, Permissions: []string{authtypes.Burner, stakingtypes.ModuleName}},
{Account: stakingtypes.NotBondedPoolName, Permissions: []string{authtypes.Burner, stakingtypes.ModuleName}},
{Account: govtypes.ModuleName, Permissions: []string{authtypes.Burner}},
{Account: nft.ModuleName},
}
7 changes: 1 addition & 6 deletions simapp/app_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func TestSimAppExportAndBlockedAddrs(t *testing.T) {
AppOpts: simtestutil.NewAppOptionsWithFlagHome(DefaultNodeHome),
})

for acc := range maccPerms {
for acc := range GetMaccPerms() {
require.True(
t,
app.BankKeeper.BlockedAddr(app.AccountKeeper.GetModuleAddress(acc)),
Expand All @@ -63,11 +63,6 @@ func TestSimAppExportAndBlockedAddrs(t *testing.T) {
require.NoError(t, err, "ExportAppStateAndValidators should not have an error")
}

func TestGetMaccPerms(t *testing.T) {
dup := GetMaccPerms()
require.Equal(t, maccPerms, dup, "duplicated module account permissions differed from actual module account permissions")
}

func TestRunMigrations(t *testing.T) {
db := dbm.NewMemDB()
logger := log.NewTMLogger(log.NewSyncWriter(os.Stdout))
Expand Down