Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean-up SDK tools #13603

Merged
merged 9 commits into from
Oct 21, 2022
Merged

refactor: clean-up SDK tools #13603

merged 9 commits into from
Oct 21, 2022

Conversation

julienrbrt
Copy link
Member

Description

  • Rename cosmovisor module name
  • Remove /store/tools/ics23

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #13603 (d7a6c4c) into main (9a9e5b5) will increase coverage by 0.36%.
The diff coverage is n/a.

❗ Current head d7a6c4c differs from pull request most recent head c308302. Consider uploading reports for the commit c308302 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13603      +/-   ##
==========================================
+ Coverage   54.70%   55.06%   +0.36%     
==========================================
  Files         645      661      +16     
  Lines       55692    56812    +1120     
==========================================
+ Hits        30466    31286     +820     
- Misses      22737    22990     +253     
- Partials     2489     2536      +47     
Impacted Files Coverage Δ
tools/cosmovisor/args.go 87.44% <ø> (ø)
tools/cosmovisor/cmd/cosmovisor/help.go 100.00% <ø> (ø)
tools/cosmovisor/cmd/cosmovisor/init.go 75.51% <ø> (ø)
tools/cosmovisor/cmd/cosmovisor/main.go 0.00% <ø> (ø)
tools/cosmovisor/cmd/cosmovisor/run.go 23.33% <ø> (ø)
tools/cosmovisor/cmd/cosmovisor/run_config.go 0.00% <ø> (ø)
tools/cosmovisor/cmd/cosmovisor/version.go 32.00% <ø> (ø)
tools/cosmovisor/errors/multi.go 75.00% <ø> (ø)
tools/cosmovisor/logger.go 100.00% <ø> (ø)
tools/cosmovisor/process.go 51.31% <ø> (ø)
... and 20 more

@julienrbrt julienrbrt changed the title refactor: rename cosmovisor module name refactor: clean-up SDK tools Oct 20, 2022
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Would be good to have consensus with another reviewer before merge

@julienrbrt julienrbrt enabled auto-merge (squash) October 20, 2022 21:17
@julienrbrt julienrbrt enabled auto-merge (squash) October 20, 2022 21:36
@github-actions github-actions bot added the C:Cosmovisor Issues and PR related to Cosmovisor label Oct 20, 2022
@julienrbrt
Copy link
Member Author

After this I'll be tagging cosmovisor again.

@julienrbrt julienrbrt merged commit 7d6601e into main Oct 21, 2022
@julienrbrt julienrbrt deleted the julien/rename-cosmovisor branch October 21, 2022 15:15
@julienrbrt julienrbrt mentioned this pull request Oct 22, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants