Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix can't release cosmovisor #13618

Merged
merged 6 commits into from
Oct 24, 2022
Merged

ci: fix can't release cosmovisor #13618

merged 6 commits into from
Oct 24, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Oct 22, 2022

Description

The GitHub Action path was not modified in #13603:

Releasing Cosmovisor didn't work then. I have removed the tag and will re-create it after this PR.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner October 22, 2022 21:51
@julienrbrt julienrbrt enabled auto-merge (squash) October 22, 2022 21:51
@julienrbrt julienrbrt enabled auto-merge (squash) October 22, 2022 21:56
@codecov
Copy link

codecov bot commented Oct 22, 2022

Codecov Report

Merging #13618 (ebe20a1) into main (e279271) will increase coverage by 0.01%.
The diff coverage is 22.22%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13618      +/-   ##
==========================================
+ Coverage   54.67%   54.68%   +0.01%     
==========================================
  Files         645      645              
  Lines       55692    55737      +45     
==========================================
+ Hits        30449    30482      +33     
- Misses      22755    22765      +10     
- Partials     2488     2490       +2     
Impacted Files Coverage Δ
x/auth/client/cli/query.go 19.68% <0.00%> (-1.78%) ⬇️
x/auth/keeper/grpc_query.go 58.43% <52.63%> (-0.75%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️
x/auth/keeper/keeper.go 70.90% <0.00%> (+5.45%) ⬆️
x/distribution/simulation/operations.go 90.32% <0.00%> (+9.67%) ⬆️

@julienrbrt
Copy link
Member Author

julienrbrt commented Oct 23, 2022

@tac0turtle, I think you need to administrator merge this. As the tests are failing because it downloads the test files from GH, which are pointing to 404 links (which are fixed in this PR): https://github.com/cosmos/cosmos-sdk/actions/runs/3308657422/jobs/5461202278.
The first PR moving the files have passed CI without issue because then these files existed on main.

@tac0turtle tac0turtle merged commit 3b62a95 into main Oct 24, 2022
@tac0turtle tac0turtle deleted the julien/ci-cosmovisor branch October 24, 2022 10:56
@julienrbrt
Copy link
Member Author

Thank you! It works now: https://github.com/cosmos/cosmos-sdk/actions/runs/3312109769/jobs/5468383976 (just the sha needs to be updated, but we can do that in any PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants