Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: integrate rosetta-cli into rosetta-ci #13785

Merged
merged 6 commits into from
Nov 8, 2022

Conversation

JulianToledano
Copy link
Contributor

Description

Closes:
#10790


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:Rosetta Issues and PR related to Rosetta label Nov 7, 2022
@julienrbrt julienrbrt linked an issue Nov 7, 2022 that may be closed by this pull request
4 tasks
@JulianToledano JulianToledano changed the title build(rosetta): integrate rosetta-cli into rosetta-ci test: integrate rosetta-cli into rosetta-ci Nov 7, 2022
@JulianToledano JulianToledano marked this pull request as ready for review November 7, 2022 18:26
@JulianToledano JulianToledano requested a review from a team as a code owner November 7, 2022 18:26
@@ -32,7 +32,7 @@ services:
- 8080

test_rosetta:
image: tendermintdev/rosetta-cli:v0.6.7
image: rosetta-ci:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to be worried about breaking changes with using latest here?

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one small nit

contrib/rosetta/README.md Outdated Show resolved Hide resolved
@tac0turtle tac0turtle merged commit a3e1b99 into cosmos:main Nov 8, 2022
@JulianToledano JulianToledano deleted the misc/rosetta-cli-docker branch November 17, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Rosetta Issues and PR related to Rosetta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rosetta-cli docker image
3 participants