feat: sender mempool impl #13888
Merged
feat: sender mempool impl #13888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13888 +/- ##
==========================================
+ Coverage 56.25% 56.29% +0.03%
==========================================
Files 667 667
Lines 56576 56634 +58
==========================================
+ Hits 31829 31884 +55
- Misses 22165 22166 +1
- Partials 2582 2584 +2
|
alexanderbez
added
C:ABCI
backport/v0.47.x
…est to bloated when including non determinism
Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com>
kocubinski
reviewed
Nov 22, 2022
kocubinski
reviewed
Nov 22, 2022
kocubinski
approved these changes
Nov 22, 2022
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
|
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed! |
tac0turtle
approved these changes
Nov 23, 2022
mergify bot
pushed a commit
that referenced
this pull request
Nov 23, 2022
* draft sender mempool impl * select * nit * random sender update * nit * prevent memory leak * fix nil return * small fixes * added tests * change count * finish tx order test removed the three address test due to make the test to bloated when including non determinism * remove unsued variable * nit * fix * temoral commit braking * nit most * nit most * final * comments * t * comments * test * add nolint * Fix comment * golint comment * golint * improve format? * more gosec disable * Fix ctr usage * use #nosec * Update types/mempool/sender_nonce.go * Kocubinski/random sender nonce (#13956) * refactor * fix iteration logic * fix merge err * import fixes * derive order randomness from seed only * gosec fix * ignore gosec again * comments * property based * minor fixes * added property test * comment * fix imports * comment * Update types/mempool/sender_nonce_property_test.go Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com> * remove unesessary loop * improve function name * Update types/mempool/sender_nonce.go Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> * change import name * change validation to be preemvtive Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com> Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> (cherry picked from commit 908fda1) # Conflicts: # types/mempool/nonce.go
JeancarloBarrios
added a commit
that referenced
this pull request
Nov 24, 2022
tac0turtle
pushed a commit
that referenced
this pull request
Nov 24, 2022
* feat: sender mempool impl (#13888) * draft sender mempool impl * select * nit * random sender update * nit * prevent memory leak * fix nil return * small fixes * added tests * change count * finish tx order test removed the three address test due to make the test to bloated when including non determinism * remove unsued variable * nit * fix * temoral commit braking * nit most * nit most * final * comments * t * comments * test * add nolint * Fix comment * golint comment * golint * improve format? * more gosec disable * Fix ctr usage * use #nosec * Update types/mempool/sender_nonce.go * Kocubinski/random sender nonce (#13956) * refactor * fix iteration logic * fix merge err * import fixes * derive order randomness from seed only * gosec fix * ignore gosec again * comments * property based * minor fixes * added property test * comment * fix imports * comment * Update types/mempool/sender_nonce_property_test.go Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com> * remove unesessary loop * improve function name * Update types/mempool/sender_nonce.go Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> * change import name * change validation to be preemvtive Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com> Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> (cherry picked from commit 908fda1) # Conflicts: # types/mempool/nonce.go * feat: sender mempool impl (#13888) Co-authored-by: Jeancarlo Barrios <JeancarloBarrios@users.noreply.github.com> Co-authored-by: Jeancarlo <jeancarlobarrios@gmail.com>
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A summary of this mempool's behavior:
Note that PrepareProposal could choose to stop iteration before reaching the end if maxBytes is reached.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change