Kocubinski/random sender nonce #13956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocubinski
force-pushed
the
kocubinski/random-sender-nonce
branch
from
f089a6b
to
cfc2254
Compare
…ubinski/random-sender-nonce
tac0turtle
pushed a commit
that referenced
this pull request
Nov 23, 2022
* draft sender mempool impl * select * nit * random sender update * nit * prevent memory leak * fix nil return * small fixes * added tests * change count * finish tx order test removed the three address test due to make the test to bloated when including non determinism * remove unsued variable * nit * fix * temoral commit braking * nit most * nit most * final * comments * t * comments * test * add nolint * Fix comment * golint comment * golint * improve format? * more gosec disable * Fix ctr usage * use #nosec * Update types/mempool/sender_nonce.go * Kocubinski/random sender nonce (#13956) * refactor * fix iteration logic * fix merge err * import fixes * derive order randomness from seed only * gosec fix * ignore gosec again * comments * property based * minor fixes * added property test * comment * fix imports * comment * Update types/mempool/sender_nonce_property_test.go Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com> * remove unesessary loop * improve function name * Update types/mempool/sender_nonce.go Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> * change import name * change validation to be preemvtive Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com> Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Nov 23, 2022
* draft sender mempool impl * select * nit * random sender update * nit * prevent memory leak * fix nil return * small fixes * added tests * change count * finish tx order test removed the three address test due to make the test to bloated when including non determinism * remove unsued variable * nit * fix * temoral commit braking * nit most * nit most * final * comments * t * comments * test * add nolint * Fix comment * golint comment * golint * improve format? * more gosec disable * Fix ctr usage * use #nosec * Update types/mempool/sender_nonce.go * Kocubinski/random sender nonce (#13956) * refactor * fix iteration logic * fix merge err * import fixes * derive order randomness from seed only * gosec fix * ignore gosec again * comments * property based * minor fixes * added property test * comment * fix imports * comment * Update types/mempool/sender_nonce_property_test.go Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com> * remove unesessary loop * improve function name * Update types/mempool/sender_nonce.go Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> * change import name * change validation to be preemvtive Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com> Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> (cherry picked from commit 908fda1) # Conflicts: # types/mempool/nonce.go
tac0turtle
pushed a commit
that referenced
this pull request
Nov 24, 2022
* feat: sender mempool impl (#13888) * draft sender mempool impl * select * nit * random sender update * nit * prevent memory leak * fix nil return * small fixes * added tests * change count * finish tx order test removed the three address test due to make the test to bloated when including non determinism * remove unsued variable * nit * fix * temoral commit braking * nit most * nit most * final * comments * t * comments * test * add nolint * Fix comment * golint comment * golint * improve format? * more gosec disable * Fix ctr usage * use #nosec * Update types/mempool/sender_nonce.go * Kocubinski/random sender nonce (#13956) * refactor * fix iteration logic * fix merge err * import fixes * derive order randomness from seed only * gosec fix * ignore gosec again * comments * property based * minor fixes * added property test * comment * fix imports * comment * Update types/mempool/sender_nonce_property_test.go Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com> * remove unesessary loop * improve function name * Update types/mempool/sender_nonce.go Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> * change import name * change validation to be preemvtive Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com> Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> (cherry picked from commit 908fda1) # Conflicts: # types/mempool/nonce.go * feat: sender mempool impl (#13888) Co-authored-by: Jeancarlo Barrios <JeancarloBarrios@users.noreply.github.com> Co-authored-by: Jeancarlo <jeancarlobarrios@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed #13888 changes