Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: resolve IBC hash to human readable denom #14894

Merged
merged 16 commits into from
Feb 6, 2023
Merged

feat: resolve IBC hash to human readable denom #14894

merged 16 commits into from
Feb 6, 2023

Conversation

0xmuralik
Copy link
Contributor

@0xmuralik 0xmuralik commented Feb 3, 2023 •
edited
Loading

Description

Closes: #14181

Also see: cosmos/ibc-go#3104

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@0xmuralik 0xmuralik requested a review from a team as a code owner February 3, 2023 09:35
@0xmuralik 0xmuralik mentioned this pull request Feb 3, 2023
Merged
9 tasks
@0xmuralik 0xmuralik changed the title feat: return a human readable denomination for IBC vouchers when querying bank balances feat: resolve IBC hash to human readable denom Feb 3, 2023
julienrbrt
julienrbrt approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! utACK.

CHANGELOG.md Outdated Show resolved Hide resolved
likhita-809
likhita-809 approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice changes

julienrbrt
julienrbrt requested changes Feb 6, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@likhita-809
Copy link
Contributor

we migrated SDK to use CometBFT
ref: #14897
Use CometBFT instead of tendermint

likhita-809
likhita-809 requested changes Feb 6, 2023
View reviewed changes
x/bank/keeper/keeper_test.go Outdated Show resolved Hide resolved
0xmuralik and others added 3 commits February 6, 2023 15:28
@0xmuralik @julienrbrt
remove tendermint dependency
1ddeb2d 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@0xmuralik @julienrbrt
tendermint bytes=> cometbft bytes
559dcf9 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@0xmuralik
fix errors
673c259
julienrbrt
julienrbrt reviewed Feb 6, 2023
View reviewed changes
go.sum Outdated Show resolved Hide resolved
@0xmuralik @julienrbrt
Update proto comment
2737eb8 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@atheeshp atheeshp enabled auto-merge (squash) February 6, 2023 11:47
@atheeshp atheeshp merged commit ffde2b9 into cosmos:main Feb 6, 2023
samricotta pushed a commit that referenced this pull request Feb 7, 2023
@0xmuralik @julienrbrt @samricotta
feat: resolve IBC hash to human readable denom (#14894)
9e18e84 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Mar 28, 2023
Closed
19 tasks
tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023
@0xmuralik @julienrbrt @tsenart
feat: resolve IBC hash to human readable denom (cosmos#14894)
e677ea6 
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@tac0turtle tac0turtle tac0turtle left review comments

@likhita-809 likhita-809 likhita-809 approved these changes

@atheeshp atheeshp atheeshp approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@samricotta samricotta Awaiting requested review from samricotta

Assignees
No one assigned
Labels
C:CLI C:x/bank
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: return a human readable denomination for IBC vouchers when querying bank balances
6 participants
@0xmuralik @likhita-809 @alexanderbez @tac0turtle @julienrbrt @atheeshp