-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: resolve IBC hash to human readable denom #14894
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
julienrbrt and
samricotta
and removed request for
a team
February 3, 2023 09:35
9 tasks
0xmuralik
changed the title
feat: return a human readable denomination for IBC vouchers when querying bank balances
feat: resolve IBC hash to human readable denom
Feb 3, 2023
julienrbrt
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! utACK.
julienrbrt
reviewed
Feb 3, 2023
tac0turtle
reviewed
Feb 3, 2023
alexanderbez
approved these changes
Feb 3, 2023
likhita-809
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice changes
julienrbrt
requested changes
Feb 6, 2023
we migrated SDK to use CometBFT |
julienrbrt
reviewed
Feb 6, 2023
likhita-809
requested changes
Feb 6, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Julien Robert <julien@rbrt.fr>
julienrbrt
reviewed
Feb 6, 2023
julienrbrt
approved these changes
Feb 6, 2023
julienrbrt
reviewed
Feb 6, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr>
likhita-809
approved these changes
Feb 6, 2023
atheeshp
approved these changes
Feb 6, 2023
19 tasks
tsenart
pushed a commit
to meka-dev/cosmos-sdk
that referenced
this pull request
Apr 12, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #14181
Also see: cosmos/ibc-go#3104
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change