Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve IBC hash to human readable denom #14894

Merged
merged 16 commits into from
Feb 6, 2023
Merged

feat: resolve IBC hash to human readable denom #14894

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f151205
add flag to req proto
0xmuralik Feb 2, 2023
19ed15a
make proto-gen
0xmuralik Feb 2, 2023
8825244
add flag and resolve IBC denom
0xmuralik Feb 2, 2023
068b463
add unit tests
0xmuralik Feb 3, 2023
9da7055
changelog
0xmuralik Feb 3, 2023
aca609f
Merge branch 'main' into murali/ibc-denom
0xmuralik Feb 6, 2023
f574a64
ibc-resolve=>resolve-denom
0xmuralik Feb 6, 2023
4688b87
proto-gen
0xmuralik Feb 6, 2023
8efffb8
change flag
0xmuralik Feb 6, 2023
b2abac3
edit changelog
0xmuralik Feb 6, 2023
1ddeb2d
remove tendermint dependency
0xmuralik Feb 6, 2023
559dcf9
tendermint bytes=> cometbft bytes
0xmuralik Feb 6, 2023
673c259
fix errors
0xmuralik Feb 6, 2023
67483b5
go mod tidy
0xmuralik Feb 6, 2023
2ac7904
Merge branch 'main' into murali/ibc-denom
0xmuralik Feb 6, 2023
2737eb8
Update proto comment
0xmuralik Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (client) [#14509](https://github.com/cosmos/cosmos-sdk/pull/#14509) Added `AddKeyringFlags` function.
* (x/gov,cli) [#14718](https://github.com/cosmos/cosmos-sdk/pull/14718) Added `AddGovPropFlagsToCmd` and `ReadGovPropFlags` functions.
* (store) [#14189](https://github.com/cosmos/cosmos-sdk/pull/14189) Add config `iavl-lazy-loading` to enable lazy loading of iavl store, to improve start up time of archive nodes, add method `SetLazyLoading` to `CommitMultiStore` interface.
* (x/bank) [#14894](https://github.com/cosmos/cosmos-sdk/pull/14894) Return a human readable denomination for IBC vouchers when querying bank balances. Added a `IbcResolve` parameter to `types.QueryAllBalancesRequest` and `--ibc-resolve` flag to `GetBalancesCmd()`.

### Improvements

Expand Down Expand Up @@ -243,6 +244,7 @@ extension interfaces. `module.Manager.Modules` is now of type `map[string]interf
* (store/streaming)[#14603](https://github.com/cosmos/cosmos-sdk/pull/14603) `StoreDecoderRegistry` moved from store to `types/simulations` this breaks the `AppModuleSimulation` interface.
* (x/staking) [#14590](https://github.com/cosmos/cosmos-sdk/pull/14590) `MsgUndelegateResponse` now includes undelegated amount. `x/staking` module's `keeper.Undelegate` now returns 3 values (completionTime,undelegateAmount,error) instead of 2.
* (x/feegrant) [14649](https://github.com/cosmos/cosmos-sdk/pull/14649) Extract Feegrant in its own go.mod and rename the package to `cosmossdk.io/x/feegrant`.
* (x/bank) [#14894](https://github.com/cosmos/cosmos-sdk/pull/14894) Return a human readable denomination for IBC vouchers when querying bank balances. Added a `IbcResolve` parameter to `types.QueryAllBalancesRequest`.
julienrbrt marked this conversation as resolved.
Show resolved Hide resolved

### Client Breaking Changes

Expand Down
4 changes: 2 additions & 2 deletions tests/integration/bank/keeper/deterministic_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func TestGRPCQueryAllBalances(t *testing.T) {

fundAccount(f, addr, coins...)

req := banktypes.NewQueryAllBalancesRequest(addr, testdata.PaginationGenerator(rt, uint64(numCoins)).Draw(rt, "pagination"))
req := banktypes.NewQueryAllBalancesRequest(addr, testdata.PaginationGenerator(rt, uint64(numCoins)).Draw(rt, "pagination"), false)
testdata.DeterministicIterations(f.ctx, t, req, f.queryClient.AllBalances, 0, true)
})

Expand All @@ -144,7 +144,7 @@ func TestGRPCQueryAllBalances(t *testing.T) {
)

fundAccount(f, addr1, coins...)
req := banktypes.NewQueryAllBalancesRequest(addr1, nil)
req := banktypes.NewQueryAllBalancesRequest(addr1, nil, false)

testdata.DeterministicIterations(f.ctx, t, req, f.queryClient.AllBalances, 357, false)
}
Expand Down