feat: add filtering to logger #15212
Conversation
There was a problem hiding this comment.
changes looks good, we'll need to wait till rs/zerolog#527 is merged to exclude the replace directive from go.mod file
julienrbrt
force-pushed
the
julien/log-filter
branch
from
bdace30
to
2362d56
Compare
|
failing tests |
Yes, due to #15261 (comment). However I am not removing it here as this PR touches only |
log/logger.go
Outdated
| // TODO wait for https://github.com/rs/zerolog/pull/527 to be merged | ||
| // keys := e.GetKeys() | ||
| keys := []string{} | ||
| keys, err := e.GetKeys() |
There was a problem hiding this comment.
should we make this method a function that takes keys until the pr is merged? Thinking how we can get this merged
There was a problem hiding this comment.
Unfortunately, this isn't possible. We have no way to access the log keys from the hook.
I can re-comment this line, and when the zerolog PR is merged we can uncomment it.
That works too for me.
There was a problem hiding this comment.
awesome lets do it, we can block v1 of logger till then and only release v0.1 for now
github-actions
bot
added
C:CLI
C:Confix
Description
Closes: #14967, follow-up of #15011
ref: rs/zerolog#527
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change