feat!: use cosmossdk.io/log logger
#15011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:Cosmovisor
tac0turtle
reviewed
Feb 13, 2023
github-actions
bot
added
C:Store
C:x/auth
C:x/authz
C:x/genutil
julienrbrt
force-pushed
the
julien/logging
branch
2 times, most recently
from
e2f86ea to
fba6762
Compare
github-actions
bot
added
C:Confix
|
@julienrbrt we need the pretty colours to come back. My terminal has had colourless logs for too long 😤😤 |
Totally agree 🤣. Finishing this up quickly! |
julienrbrt
force-pushed
the
julien/logging
branch
from
1795b3c to
a018f11
Compare
julienrbrt
changed the title
cosmossdk.io/log logger
julienrbrt
changed the title
cosmossdk.io/log loggercosmossdk.io/log logger
tac0turtle
approved these changes
Feb 27, 2023
julienrbrt
requested review from
alexanderbez
and removed request for
kocubinski and
atheeshp
alexanderbez
approved these changes
Feb 27, 2023
log/logger.go
Outdated
| // Impl returns the underlying logger implementation | ||
| // It is used to access the full functionalities of the underlying logger | ||
| // Advanced users can type cast the returned value to the actual logger | ||
| Impl() interface{} |
There was a problem hiding this comment.
Is the idea a user/caller would type cast, to say zerolog or zap?
There was a problem hiding this comment.
Yes, so in the SDK we can use zerolog structured API if we like after a type cast, but so that we don't leak implementation details for other to implement any other logger.
|
lets tag v1 of log since i dont think we will be touching it for a while. cleans up a lot if imports and potential replaces |
19 tasks
19 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #14967
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change