perf: start the goroutine after need to create a snapshot

[zakir-code]

Description

Avoid creating a goroutine every Commit

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• run make lint and make test
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[julienrbrt]

Hi! Thank you for your contribution, could you explain the reason for your change and what are the perf benefits?
Right now, with your change only it will create a sub go routine at each commit call, so I am not quite understanding your PR description.

[zakir-code]

Hi, I'm sorry I didn't express clearly. I think the goroutine here should be deleted, and the goroutine should be started after the shouldTakeSnapshot check is performed. The execution overhead of the shouldTakeSnapshot method is less than that of creating a goroutine. However, due to the current cosmos-sdk split into multiple go packages , so I only modified the store package.

[julienrbrt]

Could you move the changelog under unreleased?

[zakir-code]

OK

[julienrbrt]

ACK.

Would you be up to submit a follow-up PR using the latest store pseudo version that removes the other go routine from baseapp?

[zakir-code]

no problem

[julienrbrt]

It's merged, feel free to tackle the follow-up 👍🏾