perf(abci): removes the goroutine when call SnapshotIfApplicable

[zakir-code]

Description

follow-up #17158

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• run make lint and make test
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[github-actions]

Change potentially affects state.

Call sequence:

(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).Commit (baseapp/abci.go:799)

[julienrbrt]

Can you run ./scripts/go-mod-tidy-all.sh

[zakir-code]

Should ./scripts/go-mod-tidy-all.sh be added to the makefile and replace them

[tac0turtle]

any chance we can do some sort of bechmark to verify this is performance related?

[julienrbrt]

any chance we can do some sort of bechmark to verify this is performance related?

It saves a very tiny overhead (go routine creation) when it could have been avoided, but this is still beneficial. Not sure if a benchmark would be significantly show the difference.

[zakir-code]

Hi, Here is a simple benchmark test

package main

import (
	"fmt"
	"io"
	"os"
	"path/filepath"
	"testing"
)

type snapshotManager struct {
	w        io.Writer
	interval uint64
}

func newSnapshotManager(interval uint64, dir string) *snapshotManager {
	file, err := os.Create(filepath.Join(dir, "snapshot1.data"))
	if err != nil {
		panic(err)
	}
	return &snapshotManager{interval: interval, w: file}
}

func (m *snapshotManager) SnapshotIfApplicable1(height int64) {
	if m == nil {
		return
	}
	if m.interval <= 0 || uint64(height)%m.interval != 0 {
		return
	}
	go func() {
		_, _ = fmt.Fprintln(m.w, "create snapshot")
	}()
}

func (m *snapshotManager) SnapshotIfApplicable2(height int64) {
	if m == nil {
		return
	}
	if m.interval <= 0 || uint64(height)%m.interval != 0 {
		return
	}
	_, _ = fmt.Fprintln(m.w, "create snapshot")
}

func Benchmark_SnapshotIfApplicable1(b *testing.B) {
	manager := newSnapshotManager(10, b.TempDir())

	b.ResetTimer()
	for i := 0; i < b.N; i++ {
		manager.SnapshotIfApplicable1(int64(i))
	}
}

func Benchmark_SnapshotIfApplicable2(b *testing.B) {
	manager := newSnapshotManager(10, b.TempDir())

	b.ResetTimer()
	for i := 0; i < b.N; i++ {
		go manager.SnapshotIfApplicable2(int64(i))
	}
}

go version go1.20.4 darwin/amd64

go test -test.v -test.paniconexit0 -test.bench . -test.run ^$

goos: darwin
goarch: amd64
pkg: github.com/cosmos/cosmos-sdk
cpu: Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
Benchmark_SnapshotIfApplicable1
Benchmark_SnapshotIfApplicable1-12       8077500               172.3 ns/op
Benchmark_SnapshotIfApplicable2
Benchmark_SnapshotIfApplicable2-12       3608736               362.0 ns/op
PASS
ok      github.com/cosmos/cosmos-sdk        5.874s