refactor: deprecate Voteinfo in favour of Cometinfo on Context #17670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:x/slashing
C:x/distribution
tac0turtle
changed the title
github-prbot
requested review from
a team,
facundomedica and
julienrbrt
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
alexanderbez
approved these changes
Sep 10, 2023
testinginprod
approved these changes
Sep 11, 2023
julienrbrt
reviewed
Sep 11, 2023
julienrbrt
reviewed
Sep 11, 2023
tac0turtle
commented
Sep 11, 2023
x/slashing/abci.go
Outdated
| @@ -19,6 +19,10 @@ func BeginBlocker(ctx context.Context, k keeper.Keeper) error { | |||
| // store whether or not they have actually signed it and slash/unbond any | |||
| // which have missed too many blocks in a row (downtime slashing) | |||
| sdkCtx := sdk.UnwrapSDKContext(ctx) | |||
| // in testing cometInfo is nil | |||
| if sdkCtx.CometInfo() == nil { | |||
There was a problem hiding this comment.
should we change cometinfo to be a struct otherwise we need to do defensive checks
There was a problem hiding this comment.
Another advantage of a struct is that adding new fields is non breaking and everything is optional
alexanderbez
approved these changes
Sep 11, 2023
| } | ||
|
|
||
| // TODO this is Tendermint-dependent | ||
| // ref https://github.com/cosmos/cosmos-sdk/issues/3095 | ||
| if ctx.BlockHeight() > 1 { | ||
| if err := k.AllocateTokens(ctx, previousTotalPower, ctx.VoteInfos()); err != nil { | ||
| if err := k.AllocateTokens(ctx, previousTotalPower, ctx.CometInfo().LastCommit.Votes); err != nil { |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| err := k.HandleValidatorSignature(ctx, voteInfo.Validator.Address, voteInfo.Validator.Power, comet.BlockIDFlag(voteInfo.BlockIdFlag)) | ||
| for _, vote := range sdkCtx.CometInfo().LastCommit.Votes { | ||
|
|
||
| err := k.HandleValidatorSignature(ctx, vote.Validator.Address, vote.Validator.Power, vote.BlockIDFlag) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this PR marks voteinfos in context as deprecated. CometInfo provides a efficient way of getting the same data
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change