-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: deprecate Voteinfo in favour of Cometinfo on Context #17670
Merged
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
fcd47f5
depreacte voteinfo infavour of cometinfo
tac0turtle 2b04a9f
add when voteinfo will be removed
tac0turtle 2b9e3fb
fix lint
tac0turtle f111077
move depreacted comments to right of field
tac0turtle ddbb50c
change some more things
tac0turtle 9f44509
add changelog
tac0turtle f9344a9
deduplicate
tac0turtle 196af2a
fix godoc
tac0turtle dddc769
fix lint
tac0turtle 412812e
lint and fix integration tests
tac0turtle 1a17e2d
add changelog
tac0turtle 2ac8ea1
attempt to fix
tac0turtle 1df4c46
remove print
tac0turtle dd4ac2e
Merge branch 'main' into marko/migrate_vote_info_cometinfo
tac0turtle 26a7cf9
Merge branch 'main' into marko/migrate_vote_info_cometinfo
tac0turtle a498fbc
Merge branch 'main' into marko/migrate_vote_info_cometinfo
tac0turtle 0fe01dd
fix integration tests
tac0turtle 10146f0
fix distr tests
tac0turtle 48cf7f3
Merge branch 'main' into marko/migrate_vote_info_cometinfo
tac0turtle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we change cometinfo to be a struct otherwise we need to do defensive checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another advantage of a struct is that adding new fields is non breaking and everything is optional