feat(x/bank): autocli tx support #17868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
julienrbrt
reviewed
Oct 5, 2023
julienrbrt
reviewed
Oct 5, 2023
julienrbrt
reviewed
Oct 5, 2023
This comment has been minimized.
This comment has been minimized.
julienrbrt
reviewed
Oct 5, 2023
julienrbrt
reviewed
Oct 5, 2023
x/bank/autocli.go
Outdated
| RpcMethod: "Burn", | ||
| Use: "burn [from_key_or_address] [amount]", | ||
| Short: "Burns the amount specified from the given account.", | ||
| PositionalArgs: []*autocliv1.PositionalArgDescriptor{{ProtoField: "amount"}}, |
There was a problem hiding this comment.
This does not match the usage description. If you want the from_key_or_address as a positional argument, you need to add it here.
20 tasks
julienrbrt
reviewed
Oct 5, 2023
| @@ -80,7 +76,7 @@ func BenchmarkTx(b *testing.B) { | |||
| // - tx.* events: tx.fee, tx.acc_seq, tx.signature | |||
| // - Sending Amount to recipient: coin_spent, coin_received, transfer and message.sender=<val1> | |||
| // - Msg events: message.module=bank and message.action=/cosmos.bank.v1beta1.MsgSend (in one message) | |||
| assert.Equal(b, 12, len(res.GetResult().GetEvents())) | |||
| assert.Equal(b, 10, len(res.GetResult().GetEvents())) | |||
There was a problem hiding this comment.
Which ones are not send anymore?
There was a problem hiding this comment.
compared with old main commits, observed that few of the duplicate events were removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #17827
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change