Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(x/distribution): add autocli options for tx #17963

Merged
merged 23 commits into from
Oct 11, 2023
Merged

feat(x/distribution): add autocli options for tx #17963

merged 23 commits into from
Oct 11, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Oct 4, 2023 •
edited
Loading

Description

Closes: #17962

Blocked on #17913 and #17868

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the S:blocked Status: Blocked label Oct 4, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner October 4, 2023 22:53
Base automatically changed from julien/autocli-from to main October 5, 2023 11:06
@julienrbrt julienrbrt removed the S:blocked Status: Blocked label Oct 5, 2023
@julienrbrt
Copy link
Member Author

I need to add msg server tests as part of this PR.
It seems that x/distribution had no (!!!) message server tests.

@julienrbrt julienrbrt marked this pull request as draft October 5, 2023 15:11
@julienrbrt
Copy link
Member Author

I'll be partially backporting this PR (test addition, autocli config but the not other module changes that require v0.51)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Oct 9, 2023
@julienrbrt julienrbrt marked this pull request as ready for review October 9, 2023 19:59
atheeshp
atheeshp reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@atheeshp atheeshp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, there is a command from authz using address codec, that can also be refactored?

atheeshp
atheeshp reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits

x/distribution/client/cli/tx.go Show resolved Hide resolved
x/distribution/client/cli/tx.go Outdated Show resolved Hide resolved
@julienrbrt
Copy link
Member Author

julienrbrt commented Oct 10, 2023 •
edited
Loading

lgtm, there is a command from authz using address codec, that can also be refactored?

Yep, done in the authz follow-up PR (#18039).

@julienrbrt julienrbrt added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit 44934e3 Oct 11, 2023
49 of 51 checks passed
@julienrbrt julienrbrt deleted the julien/autocli-tx-distribution branch October 11, 2023 06:12
mergify bot pushed a commit that referenced this pull request Oct 11, 2023
@julienrbrt @mergify
feat(x/distribution): add autocli options for tx (#17963)
5433f86 
(cherry picked from commit 44934e3)

# Conflicts:
#	CHANGELOG.md
#	tests/e2e/distribution/suite.go
#	tests/e2e/distribution/withdraw_all_suite.go
#	x/bank/client/cli/tx.go
#	x/bank/client/cli/tx_test.go
#	x/distribution/client/cli/tx.go
#	x/distribution/client/cli/tx_test.go
#	x/distribution/keeper/keeper_test.go
#	x/protocolpool/autocli.go
#	x/staking/client/cli/tx.go
@mergify mergify bot mentioned this pull request Oct 11, 2023
Closed
@julienrbrt julienrbrt removed the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Oct 12, 2023
@coderabbitai coderabbitai bot mentioned this pull request Apr 22, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheeshp atheeshp atheeshp approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski

@testinginprod testinginprod Awaiting requested review from testinginprod testinginprod is a code owner

Assignees
No one assigned
Labels
C:CLI C:x/bank C:x/distribution distribution module related C:x/protocolpool C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AutoCLI Tx Options for x/distribution
2 participants
@julienrbrt @atheeshp