Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upstream stf to main #20286
chore: upstream stf to main #20286
Changes from 12 commits
d437ba7
0e8104f
f122075
a30918c
ef8ef4a
4f8859b
7d179c9
e4aa10a
d4ec708
e52bddd
fde83df
9f0c194
9c29118
3708b43
6434b6a
6354856
7920b94
82c693c
0badb5f
e6a75ac
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
personal preference: reserve 0 for undefined so that you can check for that if needed and not default to "ExecModeCheck"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was to keep inline with existing types. will check if its safe to break
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, let's please not break, we try to keep them in sync (so we can just cast them). See
cosmos-sdk/core/transaction/service.go
Lines 8 to 20 in fc84ff6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did that same as context, one less sdk dep throughout for baseapp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
Several files in the codebase still use the old function signature for
GetGasLimit
without handling the new error return. These files need to be updated to align with the new function signature and error handling mechanism.x/tx/signing/textual/internal/textualpb/textual.pulsar.go
types/tx/tx.pb.go
api/cosmos/tx/v1beta1/tx.pulsar.go
Analysis chain
Ensure all calls to
GetGasLimit
handle the new error return.Scripts Executed
The following scripts were executed for the analysis:
Script:
Length of output: 629