chore(all)!: use gogoproto/any instead of codec/types/any #21013
Conversation
github-actions
bot
added
C:x/staking
C:CLI
C:x/gov
C:Keys
WalkthroughWalkthroughThe recent changes in the Cosmos SDK involve a significant transition from using Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant SDK
participant gogoprotoany
Developer->>SDK: Update code to use gogoprotoany
SDK->>gogoprotoany: Call methods using AnyUnpacker
gogoprotoany-->>SDK: Return unpacked interfaces
SDK-->>Developer: Provide updated functionality and compatibility
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Outside diff range, codebase verification and nitpick comments (1)
types/result.go (1)
163-163: Update missed forUnpackInterfacesMessagetype inserver/v2/cometbft/client/grpc/cmtservice/service.goThe variable declaration has been correctly updated to use
gogoprotoany.UnpackInterfacesMessagein most places. However, there is still an instance inserver/v2/cometbft/client/grpc/cmtservice/service.gothat usescodectypes.UnpackInterfacesMessage.
- File:
server/v2/cometbft/client/grpc/cmtservice/service.go- Line:
server/v2/cometbft/client/grpc/cmtservice/service.go: _ codectypes.UnpackInterfacesMessage = &GetLatestValidatorSetResponse{}Please update this instance to use
gogoprotoany.UnpackInterfacesMessage.Analysis chain
LGTM! But verify the usage of the new
UnpackInterfacesMessagetype.The variable declaration has been correctly updated to use
gogoprotoany.UnpackInterfacesMessage.Ensure that all usages of
UnpackInterfacesMessageare updated to the new type.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all usages of `UnpackInterfacesMessage` are updated to the new type. # Test: Search for the usage of `UnpackInterfacesMessage`. Expect: Only occurrences of `gogoprotoany.UnpackInterfacesMessage`. rg --type go -A 5 $'UnpackInterfacesMessage'Length of output: 29646
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (47)
- client/grpc/cmtservice/service.go (3 hunks)
- client/keys/output_test.go (2 hunks)
- codec/codec.go (2 hunks)
- codec/types/interface_registry.go (3 hunks)
- crypto/keyring/legacy_info.go (2 hunks)
- crypto/keyring/record.go (2 hunks)
- crypto/keys/multisig/multisig.go (3 hunks)
- server/v2/cometbft/client/grpc/cmtservice/service.go (2 hunks)
- testutil/testdata/animal.go (4 hunks)
- testutil/testdata/grpc_query.go (2 hunks)
- types/result.go (3 hunks)
- types/tx/direct_aux.go (3 hunks)
- types/tx/ext.go (1 hunks)
- types/tx/msgs.go (2 hunks)
- types/tx/signing/signature.go (3 hunks)
- types/tx/types.go (5 hunks)
- x/auth/migrations/legacytx/stdsign.go (2 hunks)
- x/auth/migrations/legacytx/stdsignmsg.go (2 hunks)
- x/auth/migrations/legacytx/stdtx.go (2 hunks)
- x/auth/types/account.go (2 hunks)
- x/auth/types/genesis.go (2 hunks)
- x/auth/types/query.go (1 hunks)
- x/authz/authorization_grant.go (3 hunks)
- x/authz/genesis.go (3 hunks)
- x/authz/msgs.go (5 hunks)
- x/authz/simulation/operations.go (2 hunks)
- x/evidence/types/genesis.go (2 hunks)
- x/evidence/types/genesis_test.go (2 hunks)
- x/evidence/types/msgs.go (3 hunks)
- x/feegrant/filtered_fee.go (2 hunks)
- x/feegrant/genesis.go (2 hunks)
- x/feegrant/grant.go (2 hunks)
- x/feegrant/msgs.go (3 hunks)
- x/gov/types/v1/genesis.go (2 hunks)
- x/gov/types/v1/msgs.go (3 hunks)
- x/gov/types/v1/proposal.go (3 hunks)
- x/gov/types/v1beta1/genesis.go (2 hunks)
- x/gov/types/v1beta1/msgs.go (3 hunks)
- x/gov/types/v1beta1/proposal.go (3 hunks)
- x/group/genesis.go (2 hunks)
- x/group/msgs.go (6 hunks)
- x/group/proposal.go (2 hunks)
- x/group/simulation/operations.go (2 hunks)
- x/group/types.go (3 hunks)
- x/staking/types/genesis.go (2 hunks)
- x/staking/types/msg.go (4 hunks)
- x/staking/types/validator.go (3 hunks)
Additional context used
Path-based instructions (47)
x/auth/types/query.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.types/tx/ext.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/group/proposal.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/feegrant/genesis.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/auth/migrations/legacytx/stdsignmsg.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/staking/types/genesis.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/authz/genesis.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/evidence/types/msgs.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/evidence/types/genesis.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.types/tx/msgs.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/feegrant/msgs.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.testutil/testdata/animal.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/feegrant/grant.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/authz/authorization_grant.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.types/tx/direct_aux.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/gov/types/v1beta1/genesis.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/group/genesis.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/gov/types/v1beta1/msgs.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.testutil/testdata/grpc_query.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/authz/msgs.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/gov/types/v1/genesis.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.types/tx/signing/signature.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/evidence/types/genesis_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"crypto/keyring/record.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/gov/types/v1/proposal.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/gov/types/v1/msgs.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/feegrant/filtered_fee.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.types/result.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/auth/migrations/legacytx/stdsign.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.client/keys/output_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"codec/codec.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/auth/migrations/legacytx/stdtx.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.crypto/keys/multisig/multisig.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/auth/types/genesis.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/staking/types/msg.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.types/tx/types.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/gov/types/v1beta1/proposal.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/group/msgs.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.crypto/keyring/legacy_info.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.client/grpc/cmtservice/service.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.server/v2/cometbft/client/grpc/cmtservice/service.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/auth/types/account.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.codec/types/interface_registry.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/authz/simulation/operations.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/staking/types/validator.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/group/types.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/group/simulation/operations.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
golangci-lint
types/tx/signing/signature.go
7-7: File is not
gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order(gci)
types/result.go
13-13: File is not
gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order(gci)
codec/codec.go
9-9: File is not
gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order(gci)
crypto/keys/multisig/multisig.go
12-12: File is not
gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order(gci)
types/tx/types.go
15-15: File is not
gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order(gci)
Additional comments not posted (135)
x/auth/types/query.go (2)
8-11: LGTM! Verify the usage ofgogoprotoany.AnyUnpacker.The method signature update to use
gogoprotoany.AnyUnpackerlooks good. Ensure that all usages ofAnyUnpackerare updated accordingly.Verification successful
All usages of
AnyUnpackerhave been successfully updated togogoprotoany.AnyUnpacker.The method signature update to use
gogoprotoany.AnyUnpackeris consistently applied across the codebase.
- Files and methods updated:
x/staking/types/validator.gox/staking/types/msg.gox/staking/types/genesis.gox/group/proposal.gox/group/types.gox/group/msgs.gox/group/genesis.gox/group/simulation/operations.gox/gov/types/v1beta1/genesis.gox/gov/types/v1beta1/proposal.gox/gov/types/v1beta1/msgs.gox/gov/types/v1/proposal.gox/gov/types/v1/msgs.gox/feegrant/msgs.gox/feegrant/genesis.gox/feegrant/grant.gox/feegrant/filtered_fee.gox/authz/msgs.gox/authz/genesis.gox/authz/authorization_grant.gox/evidence/types/msgs.gox/evidence/types/genesis.gox/auth/types/query.gox/auth/types/genesis.gox/auth/types/account.gox/auth/migrations/legacytx/stdtx.gox/auth/migrations/legacytx/stdsign.gotypes/result.gotypes/tx/types.gotypes/tx/msgs.gotypes/tx/ext.gotypes/tx/direct_aux.gotypes/tx/signing/signature.gox/auth/migrations/legacytx/stdsignmsg.gotestutil/testdata/grpc_query.goserver/v2/cometbft/client/grpc/cmtservice/service.gotestutil/testdata/animal.gocrypto/keyring/legacy_info.gocrypto/keyring/record.gocrypto/keys/multisig/multisig.goclient/grpc/cmtservice/service.gocodec/codec.gocodec/types/interface_registry.gocodec/proto_codec.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all usages of `AnyUnpacker` are updated to `gogoprotoany.AnyUnpacker`. # Test: Search for the usage of `AnyUnpacker`. Expect: Only occurances of `gogoprotoany.AnyUnpacker`. rg --type go -A 5 $'AnyUnpacker'Length of output: 25136
13-13: LGTM! Verify the usage ofgogoprotoany.UnpackInterfacesMessage.The variable declaration update to use
gogoprotoany.UnpackInterfacesMessagelooks good. Ensure that all usages ofUnpackInterfacesMessageare updated accordingly.Verification successful
All instances of
UnpackInterfacesMessagehave been successfully updated togogoprotoany.UnpackInterfacesMessage.The variable declaration update and subsequent usage changes have been verified and are consistent across the codebase.
- Verified files include:
x/staking/types/validator.gox/staking/types/msg.gox/staking/types/genesis.gox/group/types.gox/group/proposal.gox/group/msgs.gox/group/genesis.gox/gov/types/v1beta1/proposal.gox/gov/types/v1beta1/msgs.gox/gov/types/v1beta1/genesis.gox/gov/types/v1/proposal.gox/gov/types/v1/msgs.gox/gov/types/v1/genesis.gox/feegrant/msgs.gox/feegrant/grant.gox/feegrant/genesis.gox/feegrant/filtered_fee.gox/evidence/types/msgs.gox/evidence/types/genesis.gox/authz/msgs.gox/authz/authorization_grant.gox/authz/genesis.gox/auth/migrations/legacytx/stdtx.gox/auth/migrations/legacytx/stdsignmsg.gotypes/result.gox/auth/types/query.gox/auth/types/account.gotypes/tx/types.gotypes/tx/signing/signature.gotestutil/testdata/grpc_query.gotestutil/testdata/animal.gox/auth/types/genesis.goserver/v2/cometbft/client/grpc/cmtservice/service.gocrypto/keys/multisig/multisig.gocrypto/keyring/legacy_info.gocrypto/keyring/record.gocodec/types/interface_registry.gocodec/any_test.goclient/grpc/cmtservice/service.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all usages of `UnpackInterfacesMessage` are updated to `gogoprotoany.UnpackInterfacesMessage`. # Test: Search for the usage of `UnpackInterfacesMessage`. Expect: Only occurances of `gogoprotoany.UnpackInterfacesMessage`. rg --type go -A 5 $'UnpackInterfacesMessage'Length of output: 29646
types/tx/ext.go (1)
Line range hint
12-20: LGTM! Verify the usage ofgogoprotoany.AnyUnpacker.The function signature update to use
gogoprotoany.AnyUnpackerlooks good. Ensure that all usages ofAnyUnpackerare updated accordingly.Verification successful
Verification successful!
All instances of
AnyUnpackerhave been correctly updated togogoprotoany.AnyUnpackeracross the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all usages of `AnyUnpacker` are updated to `gogoprotoany.AnyUnpacker`. # Test: Search for the usage of `AnyUnpacker`. Expect: Only occurances of `gogoprotoany.AnyUnpacker`. rg --type go -A 5 $'AnyUnpacker'Length of output: 25136
x/group/proposal.go (1)
25-27: LGTM! Verify the usage ofgogoprotoany.AnyUnpacker.The method signature update to use
gogoprotoany.AnyUnpackerlooks good. Ensure that all usages ofAnyUnpackerare updated accordingly.Verification successful
Verification successful!
The usage of
gogoprotoany.AnyUnpackeris consistent across the codebase, confirming the update fromtypes.AnyUnpackertogogoprotoany.AnyUnpackerhas been correctly applied.
- All instances of
AnyUnpackerare now usinggogoprotoany.AnyUnpacker.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all usages of `AnyUnpacker` are updated to `gogoprotoany.AnyUnpacker`. # Test: Search for the usage of `AnyUnpacker`. Expect: Only occurances of `gogoprotoany.AnyUnpacker`. rg --type go -A 5 $'AnyUnpacker'Length of output: 25136
x/feegrant/genesis.go (3)
4-4: LGTM!The import statement has been correctly updated to use
gogoprotoanyinstead oftypes.
7-7: LGTM!The variable declaration has been correctly updated to reflect the new
gogoprotoany.UnpackInterfacesMessageinterface.
37-37: LGTM!The function signature has been correctly updated to use
gogoprotoany.AnyUnpackerinstead oftypes.AnyUnpacker.x/auth/migrations/legacytx/stdsignmsg.go (3)
6-6: LGTM!The import statement has been correctly updated to use
gogoprotoanyinstead oftypes.
9-9: LGTM!The variable declaration has been correctly updated to reflect the new
gogoprotoany.UnpackInterfacesMessageinterface.
23-23: LGTM!The function signature has been correctly updated to use
gogoprotoany.AnyUnpackerinstead oftypes.AnyUnpacker.x/staking/types/genesis.go (2)
7-7: LGTM!The import statement has been correctly updated to use
gogoprotoanyinstead ofcodectypes.
39-39: LGTM!The function signature has been correctly updated to use
gogoprotoany.AnyUnpackerinstead ofcodectypes.AnyUnpacker.x/authz/genesis.go (3)
6-6: Import change approved.The import statement for
cdctypesis correctly replaced withgogoprotoany.
35-35: Interface implementation change approved.The interface implementation for
GenesisStateis correctly updated fromcdctypes.UnpackInterfacesMessagetogogoprotoany.UnpackInterfacesMessage.
Line range hint
38-49: Method signature changes approved.The method signatures for
UnpackInterfacesinGenesisStateandGrantAuthorizationare correctly updated to usegogoprotoany.AnyUnpackerinstead ofcdctypes.AnyUnpacker.x/evidence/types/msgs.go (3)
7-7: Import change approved.The import statement for
gogoprotoanyis correctly added.
17-17: Interface implementation change approved.The interface implementation for
MsgSubmitEvidenceis correctly updated fromtypes.UnpackInterfacesMessagetogogoprotoany.UnpackInterfacesMessage.
55-55: Method signature change approved.The method signature for
UnpackInterfacesinMsgSubmitEvidenceis correctly updated to usegogoprotoany.AnyUnpackerinstead oftypes.AnyUnpacker.x/evidence/types/genesis.go (3)
12-12: Import change approved.The import statement for
gogoprotoanyis correctly added.
15-15: Interface implementation change approved.The interface implementation for
GenesisStateis correctly updated fromtypes.UnpackInterfacesMessagetogogoprotoany.UnpackInterfacesMessage.
60-60: Method signature change approved.The method signature for
UnpackInterfacesinGenesisStateis correctly updated to usegogoprotoany.AnyUnpackerinstead oftypes.AnyUnpacker.types/tx/msgs.go (2)
8-8: Importgogoprotoanycorrectly.The new import statement for
gogoprotoanyis correctly added.
Line range hint
57-64:
Update function signature forUnpackInterfaces.The function signature is updated to use
gogoprotoany.AnyUnpacker, which aligns with the new import. Ensure that this change is propagated throughout the codebase where this function is called.x/feegrant/msgs.go (3)
5-5: Importgogoprotoanycorrectly.The new import statement for
gogoprotoanyis correctly added.
15-16: Update variable declarations forMsgGrantAllowance.The variable declarations are updated to use
gogoprotoany.UnpackInterfacesMessage, which aligns with the new import. This change enhances type safety and functionality.
48-50: Update method signature forUnpackInterfaces.The method signature for
UnpackInterfacesin theMsgGrantAllowancestruct is updated to usegogoprotoany.AnyUnpacker, ensuring consistency with the new import.testutil/testdata/animal.go (7)
7-7: Importgogoprotoanycorrectly.The new import statement for
gogoprotoanyis correctly added.
34-34: Update variable declaration forHasAnimal.The variable declaration is updated to use
gogoprotoany.UnpackInterfacesMessage, which aligns with the new import.
36-38: Update method signature forUnpackInterfacesinHasAnimal.The method signature is updated to use
gogoprotoany.AnyUnpacker, ensuring consistency with the new import.
61-61: Update variable declaration forHasHasAnimal.The variable declaration is updated to use
gogoprotoany.UnpackInterfacesMessage, which aligns with the new import.
63-65: Update method signature forUnpackInterfacesinHasHasAnimal.The method signature is updated to use
gogoprotoany.AnyUnpacker, ensuring consistency with the new import.
78-78: Update variable declaration forHasHasHasAnimal.The variable declaration is updated to use
gogoprotoany.UnpackInterfacesMessage, which aligns with the new import.
80-82: Update method signature forUnpackInterfacesinHasHasHasAnimal.The method signature is updated to use
gogoprotoany.AnyUnpacker, ensuring consistency with the new import.x/feegrant/grant.go (3)
10-10: Import change approved.The import of
gogoprotoanyis necessary for the updated interface handling.
13-13: Interface assertion change approved.The change from
types.UnpackInterfacesMessagetogogoprotoany.UnpackInterfacesMessagealigns with the new library usage.
66-69: Function signature change approved.The update from
types.AnyUnpackertogogoprotoany.AnyUnpackeris consistent with the new library usage. The function logic remains unchanged.x/authz/authorization_grant.go (4)
10-10: Import change approved.The import of
gogoprotoanyis necessary for the updated interface handling.
24-27: Function implementation change approved.The update from
cdctypes.NewAnyWithValuetogogoprotoany.NewAnyWithCacheWithValueis consistent with the new library usage and likely improves efficiency.
34-34: Interface assertion change approved.The change from
cdctypes.UnpackInterfacesMessagetogogoprotoany.UnpackInterfacesMessagealigns with the new library usage.
37-40: Function signature change approved.The update from
cdctypes.AnyUnpackertogogoprotoany.AnyUnpackeris consistent with the new library usage. The function logic remains unchanged.types/tx/direct_aux.go (3)
7-7: Import change approved.The import of
gogoprotoanyis necessary for the updated interface handling.
24-26: Function signature change approved.The update from
codectypes.AnyUnpackertogogoprotoany.AnyUnpackeris consistent with the new library usage. The function logic remains unchanged.
63-65: Function signature change approved.The update from
codectypes.AnyUnpackertogogoprotoany.AnyUnpackeris consistent with the new library usage. The function logic remains unchanged.x/gov/types/v1beta1/genesis.go (4)
7-7: Import statement change approved.The import statement for
gogoprotoanyis correctly added and necessary for the updated functionality.
68-68: Declaration change approved.The declaration for
GenesisStateimplementinggogoprotoany.UnpackInterfacesMessageis correct and necessary for the new package.
71-71: Method signature change approved.The method signature for
UnpackInterfacesacceptinggogoprotoany.AnyUnpackeris correct and necessary for the new package.
Line range hint
72-78:
Method implementation change approved.The method implementation for
UnpackInterfacesis correct and adheres to the new package requirements.x/group/genesis.go (3)
9-9: Import statement change approved.The import statement for
gogoprotoanyis correctly added and necessary for the updated functionality.
86-86: Method signature change approved.The method signature for
UnpackInterfacesacceptinggogoprotoany.AnyUnpackeris correct and necessary for the new package.
Line range hint
87-97:
Method implementation change approved.The method implementation for
UnpackInterfacesis correct and adheres to the new package requirements.x/gov/types/v1beta1/msgs.go (4)
7-7: Import statement change approved.The import statement for
gogoprotoanyis correctly added and necessary for the updated functionality.
24-24: Declaration change approved.The declaration for
MsgSubmitProposalimplementinggogoprotoany.UnpackInterfacesMessageis correct and necessary for the new package.
77-77: Method signature change approved.The method signature for
UnpackInterfacesacceptinggogoprotoany.AnyUnpackeris correct and necessary for the new package.
78-80: Method implementation change approved.The method implementation for
UnpackInterfacesis correct and adheres to the new package requirements.testutil/testdata/grpc_query.go (5)
8-8: Import statement forgogoprotoanylooks good.The import statement correctly adds the necessary package for handling
Anytypes.
53-53: Interface implementation forTestAnyRequestupdated correctly.The change aligns with the new
gogoprotoanylibrary.
55-57:UnpackInterfacesmethod forTestAnyRequestupdated correctly.The method signature and implementation align with the new
gogoprotoanylibrary.
60-60: Interface implementation forTestAnyResponseupdated correctly.The change aligns with the new
gogoprotoanylibrary.
62-64:UnpackInterfacesmethod forTestAnyResponseupdated correctly.The method signature and implementation align with the new
gogoprotoanylibrary.x/authz/msgs.go (6)
7-7: Import statement forgogoprotoanylooks good.The import statement correctly adds the necessary package for handling
Anytypes.
19-19: Interface implementation forMsgGrantupdated correctly.The change aligns with the new
gogoprotoanylibrary.
20-20: Interface implementation forMsgExecupdated correctly.The change aligns with the new
gogoprotoanylibrary.
48-51:SetAuthorizationmethod inMsgGrantupdated correctly.The method signature and implementation align with the new
gogoprotoanylibrary.
Line range hint
57-64:
UnpackInterfacesmethod inMsgExecupdated correctly.The method signature and implementation align with the new
gogoprotoanylibrary.
70-72:UnpackInterfacesmethod inMsgGrantupdated correctly.The method signature and implementation align with the new
gogoprotoanylibrary.x/gov/types/v1/genesis.go (3)
7-7: Import statement forgogoprotoanylooks good.The import statement correctly adds the necessary package for handling
Anytypes.
109-111: Interface implementation forGenesisStateupdated correctly.The change aligns with the new
gogoprotoanylibrary.
Line range hint
112-117:
UnpackInterfacesmethod inGenesisStateupdated correctly.The method signature and implementation align with the new
gogoprotoanylibrary.types/tx/signing/signature.go (3)
89-89: LGTM!The variable declaration has been correctly updated to use
gogoprotoany.UnpackInterfacesMessage.
Line range hint
92-100:
LGTM!The function
UnpackInterfacesinSignatureDescriptorshas been correctly updated to usegogoprotoany.AnyUnpacker.
104-106: LGTM!The function
UnpackInterfacesinSignatureDescriptorhas been correctly updated to usegogoprotoany.AnyUnpacker.x/evidence/types/genesis_test.go (1)
134-136: LGTM!The
unpackerfield in thetestCasesstruct within theTestUnpackInterfacesfunction has been correctly updated to usegogoprotoany.AnyUnpacker.crypto/keyring/record.go (1)
Line range hint
107-114:
LGTM!The function
UnpackInterfacesinRecordhas been correctly updated to usegogoprotoany.AnyUnpacker.x/gov/types/v1/proposal.go (3)
78-79: LGTM!The function correctly implements the new unpacking mechanism using
gogoprotoany.AnyUnpacker.
85-85: LGTM!The type assertion is correctly updated to use
gogoprotoany.UnpackInterfacesMessage.
Line range hint
98-104: LGTM!The function correctly implements the new unpacking mechanism using
gogoprotoany.AnyUnpacker.x/gov/types/v1/msgs.go (4)
16-16: LGTM!The new message type
&MsgSubmitMultipleChoiceProposal{}is correctly added to the variable declaration.
17-17: LGTM!The type assertion is correctly updated to use
gogoprotoany.UnpackInterfacesMessage.
64-65: LGTM!The function correctly implements the new unpacking mechanism using
gogoprotoany.AnyUnpacker.
124-126: LGTM!The function correctly implements the new unpacking mechanism using
gogoprotoany.AnyUnpacker.x/feegrant/filtered_fee.go (2)
28-28: LGTM!The type assertion is correctly updated to use
gogoprotoany.UnpackInterfacesMessage.
32-34: LGTM!The function correctly implements the new unpacking mechanism using
gogoprotoany.AnyUnpacker.types/result.go (2)
Line range hint
169-174:
LGTM! But verify the function usage in the codebase.The
UnpackInterfacesmethod forSearchTxsResulthas been correctly updated to usegogoprotoany.AnyUnpacker.Ensure that all function calls to
UnpackInterfacesmatch the new signature.Verification successful
Verified: The function usage for
UnpackInterfacesinSearchTxsResultmatches the new signature. No additional calls to this method were found in the codebase.
- The method
UnpackInterfacesforSearchTxsResultis correctly updated to usegogoprotoany.AnyUnpacker.- No other occurrences of calls to
SearchTxsResult.UnpackInterfaceswere found.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `UnpackInterfaces` match the new signature for `SearchTxsResult`. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SearchTxsResult) UnpackInterfaces'Length of output: 155
Script:
#!/bin/bash # Description: Verify all function calls to `UnpackInterfaces` match the new signature for `SearchTxsResult`. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 'func (s SearchTxsResult) UnpackInterfaces'Length of output: 63
Script:
#!/bin/bash # Description: Verify all function calls to `UnpackInterfaces` match the new signature for `SearchTxsResult`. # Test: Search for all occurrences of `UnpackInterfaces`. Expect: Only occurrences of the new signature. rg --type go 'UnpackInterfaces'Length of output: 20000
Line range hint
180-185:
LGTM! But verify the function usage in the codebase.The
UnpackInterfacesmethod forTxResponsehas been correctly updated to usegogoprotoany.AnyUnpacker.Ensure that all function calls to
UnpackInterfacesmatch the new signature.Verification successful
No issues found with the
UnpackInterfacesmethod forTxResponse.The method has been correctly updated to use
gogoprotoany.AnyUnpacker, and there are no direct calls to this method elsewhere in the codebase that would be impacted by the change.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `UnpackInterfaces` match the new signature for `TxResponse`. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'TxResponse) UnpackInterfaces'Length of output: 140
Script:
#!/bin/bash # Description: Verify all function calls to `UnpackInterfaces` match the new signature for `TxResponse`. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 'TxResponse\) UnpackInterfaces'Length of output: 316
Script:
#!/bin/bash # Description: Search for any calls to `UnpackInterfaces` across the codebase, including potential interface implementations. # Test: Search for the function usage. Expect: Any occurrences of the method being called. rg --type go 'UnpackInterfaces'Length of output: 20000
x/auth/migrations/legacytx/stdsign.go (1)
133-134: LGTM! But verify the function usage in the codebase.The
UnpackInterfacesmethod forStdSignaturehas been correctly updated to usegogoprotoany.AnyUnpacker.Ensure that all function calls to
UnpackInterfacesmatch the new signature.Verification successful
Verification successful!
The
UnpackInterfacesmethod forStdSignaturehas been correctly updated to usegogoprotoany.AnyUnpacker, and there are no additional calls to this method in the codebase that require changes.
- No further action needed.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `UnpackInterfaces` match the new signature for `StdSignature`. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'StdSignature) UnpackInterfaces'Length of output: 146
Script:
#!/bin/bash # Description: Verify all function calls to `UnpackInterfaces` match the new signature for `StdSignature`. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'StdSignature\\) UnpackInterfaces'Length of output: 598
Script:
#!/bin/bash # Description: Verify all function calls to `UnpackInterfaces` match the new signature for `StdSignature`. # Test: Search for any calls to `UnpackInterfaces`. Expect: Only occurrences of the new signature. rg --type go 'UnpackInterfaces'Length of output: 20000
client/keys/output_test.go (1)
106-125: LGTM! The new test functionTestNestedMultisigOutputis well-implemented.The test function correctly validates the functionality of nested multisignature keys.
codec/codec.go (1)
80-80: LGTM!The type definition is correctly updated to use
gogoprotoany.AnyUnpacker.x/auth/migrations/legacytx/stdtx.go (3)
17-17: LGTM!The interface implementation check is correctly updated to use
gogoprotoany.UnpackInterfacesMessage.
19-19: LGTM!The interface implementation check is correctly updated to use
gogoprotoany.UnpackInterfacesMessage.
Line range hint
173-182: LGTM!The method signature is correctly updated to use
gogoprotoany.AnyUnpacker.crypto/keys/multisig/multisig.go (2)
17-17: LGTM!The interface implementation check is correctly updated to use
gogoprotoany.UnpackInterfacesMessage.
Line range hint
153-159: LGTM!The method signature is correctly updated to use
gogoprotoany.AnyUnpacker.x/auth/types/genesis.go (3)
10-10: Import statement update approved.The import statement has been updated to include the
gogoprotoanypackage, which is necessary for the new implementation of theUnpackInterfacesMessageinterface.
18-18: Variable declaration update approved.The variable declaration has been updated to use
gogoprotoany.UnpackInterfacesMessage, which is necessary for the new implementation.
Line range hint
36-43: Method signature update approved.The method signature for
UnpackInterfaceshas been updated to usegogoprotoany.AnyUnpacker. The function logic remains correct and consistent.However, ensure that all function calls to
UnpackInterfacesmatch the new signature.Verification successful
The review of the provided output indicates that all instances of the
UnpackInterfacesfunction use the new signature withgogoprotoany.AnyUnpacker. Therefore, the function calls match the updated method signature.
- Files and lines verified:
x/staking/types/validator.gox/staking/types/msg.gox/staking/types/genesis.gox/group/types.gox/group/proposal.gox/group/msgs.gox/group/genesis.gox/gov/types/v1beta1/msgs.gox/gov/types/v1beta1/genesis.gox/gov/types/v1beta1/proposal.gox/gov/types/v1/msgs.gox/gov/types/v1/genesis.gox/feegrant/grant.gox/feegrant/msgs.gox/feegrant/genesis.gox/feegrant/filtered_fee.gox/authz/msgs.gox/authz/authorization_grant.gox/auth/types/genesis.gox/auth/types/query.gox/auth/types/account.gox/authz/simulation/operations.gox/auth/migrations/legacytx/stdtx.gox/auth/migrations/legacytx/stdsign.gox/authz/genesis.gotypes/result.gotypes/tx/direct_aux.gotypes/tx/types.gotypes/tx/signing/signature.gotestutil/testdata/grpc_query.gotestutil/testdata/animal.gotests/integration/server/grpc/server_test.gox/evidence/types/msgs.gox/evidence/types/genesis_test.gox/evidence/types/genesis.goclient/grpc_query.gocodec/json.gocodec/any_test.gocodec/amino.goclient/grpc/cmtservice/service.gocodec/types/interface_registry.gocodec/types/types_test.gocodec/proto_codec.goConclusion: All function calls to
UnpackInterfacesmatch the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `UnpackInterfaces` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'UnpackInterfaces'Length of output: 48161
x/staking/types/msg.go (5)
8-8: Import statement update approved.The import statement has been updated to include the
gogoprotoanypackage, which is necessary for the new implementation of theUnpackInterfacesMessageinterface.
17-18: Variable declaration update approved.The variable declaration for
MsgCreateValidatorhas been updated to usegogoprotoany.UnpackInterfacesMessage, which is necessary for the new implementation.
93-95: Method signature update approved.The method signature for
UnpackInterfacesinMsgCreateValidatorhas been updated to usegogoprotoany.AnyUnpacker. The function logic remains correct and consistent.However, ensure that all function calls to
UnpackInterfacesmatch the new signature.Verification successful
Method signature update confirmed.
The method signature for
UnpackInterfacesinMsgCreateValidatorhas been correctly updated to usegogoprotoany.AnyUnpacker, and this update is consistent across all instances in the codebase.
- Verified instances in:
types/result.gox/staking/types/validator.gox/staking/types/msg.gox/staking/types/genesis.gox/gov/types/v1beta1/proposal.gox/gov/types/v1beta1/msgs.gox/gov/types/v1/genesis.gox/feegrant/msgs.gox/feegrant/grant.gox/feegrant/genesis.gox/feegrant/filtered_fee.gox/evidence/types/msgs.gox/authz/msgs.gox/authz/genesis.gox/auth/types/query.gox/auth/types/genesis.gox/auth/types/account.gox/group/proposal.gox/group/msgs.gotypes/tx/types.gotypes/tx/signing/signature.gotypes/tx/direct_aux.gocrypto/keys/multisig/multisig.gocrypto/keyring/record.gocrypto/keyring/legacy_info.gocodec/types/types_test.gocodec/proto_codec.gocodec/json.goclient/grpc/cmtservice/service.gocodec/types/interface_registry.goclient/grpc_query.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `UnpackInterfaces` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'UnpackInterfaces'Length of output: 48161
164-166: Method signature update approved.The method signature for
UnpackInterfacesinMsgRotateConsPubKeyhas been updated to usegogoprotoany.AnyUnpacker. The function logic remains correct and consistent.However, ensure that all function calls to
UnpackInterfacesmatch the new signature.Verification successful
All function calls to
UnpackInterfacesmatch the new signature.The verification confirms that all instances of
UnpackInterfacesacross the codebase use thegogoprotoany.AnyUnpackerparameter, ensuring consistency with the updated method signature.
- No further action required.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `UnpackInterfaces` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'UnpackInterfaces'Length of output: 48161
Line range hint
170-177: Method signature update approved.The method signature for
UnpackInterfacesinConsPubKeyRotationHistoryhas been updated to usegogoprotoany.AnyUnpacker. The function logic remains correct and consistent.However, ensure that all function calls to
UnpackInterfacesmatch the new signature.Verification successful
All function calls to
UnpackInterfacesmatch the new signature.The verification script output confirms that the function
UnpackInterfacesconsistently uses thegogoprotoany.AnyUnpackertype across the codebase.
- Files and lines verified:
x/staking/types/validator.gox/staking/types/genesis.gox/staking/types/msg.gox/group/types.gox/group/proposal.gox/group/msgs.gox/group/genesis.gox/gov/types/v1beta1/proposal.gox/gov/types/v1beta1/msgs.gox/gov/types/v1beta1/genesis.gox/gov/types/v1/proposal.gox/gov/types/v1/msgs.gox/gov/types/v1/genesis.gox/feegrant/msgs.gox/feegrant/grant.gox/feegrant/genesis.gox/feegrant/filtered_fee.gox/evidence/types/msgs.gox/evidence/types/genesis.gox/authz/msgs.gox/authz/authorization_grant.gox/authz/simulation/operations.gox/authz/genesis.gox/auth/types/query.gox/auth/types/genesis.gox/auth/types/account.gox/auth/migrations/legacytx/stdtx.gox/auth/migrations/legacytx/stdsignmsg.gox/auth/migrations/legacytx/stdsign.gotypes/result.gotypes/tx/types.gotypes/tx/msgs.gotypes/tx/direct_aux.gotypes/tx/signing/signature.gocodec/types/interface_registry.gocodec/types/types_test.gocodec/proto_codec.gocodec/json.gocodec/any_test.gocodec/amino.gocrypto/keys/multisig/multisig.gocrypto/keyring/record.gocrypto/keyring/legacy_info.goclient/grpc_query.goclient/grpc/cmtservice/service.goserver/v2/cometbft/client/grpc/cmtservice/service.goserver/v2/api/grpc/server.gotestutil/testdata/grpc_query.gotestutil/testdata/animal.gotests/integration/server/grpc/server_test.gotests/e2e/authz/grpc.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `UnpackInterfaces` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'UnpackInterfaces'Length of output: 48161
types/tx/types.go (6)
15-15: Import statement update approved.The import statement has been updated to include the
gogoprotoanypackage, which is necessary for the new implementation of theUnpackInterfacesMessageinterface.Tools
golangci-lint
15-15: File is not
gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order(gci)
23-23: Variable declaration update approved.The variable declaration for
Tx,TxBody,AuthInfo, andSignerInfohas been updated to usegogoprotoany.UnpackInterfacesMessage, which is necessary for the new implementation.
Line range hint
180-191: Method signature update approved.The method signature for
UnpackInterfacesinTxhas been updated to usegogoprotoany.AnyUnpacker. The function logic remains correct and consistent.However, ensure that all function calls to
UnpackInterfacesmatch the new signature.
Line range hint
195-205: Method signature update approved.The method signature for
UnpackInterfacesinTxBodyhas been updated to usegogoprotoany.AnyUnpacker. The function logic remains correct and consistent.However, ensure that all function calls to
UnpackInterfacesmatch the new signature.Verification successful
Method signature update approved.
The method signature for
UnpackInterfacesinTxBodyhas been updated to usegogoprotoany.AnyUnpacker. The function logic remains correct and consistent. All function calls toUnpackInterfacesin the codebase match the new signature.
- Verified instances in:
x/staking/types/validator.gox/staking/types/msg.gox/group/types.gox/gov/types/v1beta1/proposal.gox/feegrant/msgs.gox/authz/msgs.gotypes/tx/types.gocrypto/keys/multisig/multisig.gocrypto/keyring/record.gocodec/types/interface_registry.goclient/grpc_query.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `UnpackInterfaces` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'UnpackInterfaces'Length of output: 48161
Line range hint
212-216: Method signature update approved.The method signature for
UnpackInterfacesinAuthInfohas been updated to usegogoprotoany.AnyUnpacker. The function logic remains correct and consistent.However, ensure that all function calls to
UnpackInterfacesmatch the new signature.Verification successful
Ensure all function calls to
UnpackInterfacesmatch the new signature.The method signature for
UnpackInterfacesinAuthInfohas been updated to usegogoprotoany.AnyUnpacker. The function logic remains correct and consistent. The script output shows multiple instances ofUnpackInterfaces, and it appears that the new signature is being used consistently.
- Files to verify for correct usage:
x/staking/types/validator.gox/staking/types/msg.gox/staking/types/genesis.gox/group/types.gox/group/proposal.gox/group/msgs.gox/group/genesis.gox/gov/types/v1beta1/proposal.gox/gov/types/v1beta1/msgs.gox/gov/types/v1beta1/genesis.gox/gov/types/v1/proposal.gox/gov/types/v1/genesis.gox/gov/types/v1/msgs.gox/feegrant/msgs.gox/feegrant/genesis.gox/feegrant/filtered_fee.gox/evidence/types/msgs.gox/evidence/types/genesis.gox/authz/genesis.gox/authz/authorization_grant.gox/authz/msgs.gox/auth/types/query.gox/auth/types/genesis.gox/auth/types/account.gotypes/result.gotypes/tx/types.gotypes/tx/msgs.gotypes/tx/direct_aux.gotypes/tx/signing/signature.gox/auth/migrations/legacytx/stdsignmsg.gox/auth/migrations/legacytx/stdsign.gox/auth/migrations/legacytx/stdtx.gocrypto/keyring/record.gocrypto/keyring/legacy_info.gocrypto/keys/multisig/multisig.gocodec/types/interface_registry.gocodec/proto_codec.gocodec/json.goclient/grpc_query.goclient/grpc/cmtservice/service.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `UnpackInterfaces` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'UnpackInterfaces'Length of output: 48161
223-225: Method signature update approved.The method signature for
UnpackInterfacesinSignerInfohas been updated to usegogoprotoany.AnyUnpacker. The function logic remains correct and consistent.However, ensure that all function calls to
UnpackInterfacesmatch the new signature.Verification successful
Method signature update approved.
The method signature for
UnpackInterfacesinSignerInfohas been updated to usegogoprotoany.AnyUnpacker. The function logic remains correct and consistent. All function calls toUnpackInterfacesacross the codebase match the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `UnpackInterfaces` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'UnpackInterfaces'Length of output: 48161
x/gov/types/v1beta1/proposal.go (3)
85-87: LGTM!The change to use
gogoprotoany.AnyUnpackeris consistent with the PR objectives and appears correct.
93-93: LGTM!The change to implement
gogoprotoany.UnpackInterfacesMessageforProposalsis consistent with the PR objectives and appears correct.
Line range hint
122-127:
LGTM!The change to use
gogoprotoany.AnyUnpackeris consistent with the PR objectives and appears correct.x/group/msgs.go (5)
31-33: LGTM!The change to implement
gogoprotoany.UnpackInterfacesMessageforMsgCreateGroupPolicy,MsgUpdateGroupPolicyDecisionPolicy, andMsgCreateGroupWithPolicyis consistent with the PR objectives and appears correct.
87-89: LGTM!The change to use
gogoprotoany.AnyUnpackeris consistent with the PR objectives and appears correct.
130-132: LGTM!The change to use
gogoprotoany.AnyUnpackeris consistent with the PR objectives and appears correct.
184-186: LGTM!The change to use
gogoprotoany.AnyUnpackeris consistent with the PR objectives and appears correct.
222-224: LGTM!The change to use
gogoprotoany.AnyUnpackeris consistent with the PR objectives and appears correct.crypto/keyring/legacy_info.go (1)
222-224: LGTM!The change to use
gogoprotoany.AnyUnpackeris consistent with the PR objectives and appears correct.client/grpc/cmtservice/service.go (2)
8-8: Import statement forgogoprotoanylooks good.The import statement is necessary for the changes made in this file.
Line range hint
116-124: Method signature change forUnpackInterfaceslooks good.The method signature has been updated to use
gogoprotoany.AnyUnpacker, and the logic remains intact.Ensure that all calls to this method are updated to match the new signature.
Verification successful
Method signature change for
UnpackInterfaceslooks good.The method signature has been updated to use
gogoprotoany.AnyUnpacker, and all calls to this method in the codebase match the new signature.
- Verified files include:
x/staking/types/validator.gox/staking/types/msg.gox/group/types.gox/group/proposal.gox/gov/types/v1/proposal.gox/auth/types/query.gox/auth/types/genesis.gox/auth/migrations/legacytx/stdtx.gotypes/result.gotypes/tx/types.gox/authz/authorization_grant.gocrypto/keyring/legacy_info.gocrypto/keys/multisig/multisig.gocrypto/keyring/record.gocodec/types/interface_registry.goclient/grpc_query.goclient/grpc/cmtservice/service.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all calls to `UnpackInterfaces` match the new signature. # Test: Search for the method usage. Expect: Only occurances of the new signature. rg --type go -A 5 $'UnpackInterfaces'Length of output: 48161
server/v2/cometbft/client/grpc/cmtservice/service.go (2)
11-11: Import statement forgogoprotoanylooks good.The import statement is necessary for the changes made in this file.
Line range hint
135-143: Method signature change forUnpackInterfaceslooks good.The method signature has been updated to use
gogoprotoany.AnyUnpacker, and the logic remains intact.Ensure that all calls to this method are updated to match the new signature.
Verification successful
Method signature change for
UnpackInterfacesis correctly implemented.All calls to the
UnpackInterfacesmethod have been updated to usegogoprotoany.AnyUnpackeras the parameter type.
server/v2/cometbft/client/grpc/cmtservice/service.goline 132x/staking/types/validator.golines 2 and 10x/staking/types/msg.golines 2, 10, 18, 26, and 34x/group/types.golines 2, 10, 18, 26, 34, and 42x/group/proposal.goline 2x/group/msgs.golines 2, 10, 18, 26, 34, and 42x/group/genesis.goline 2x/gov/types/v1beta1/proposal.golines 2 and 10x/gov/types/v1/proposal.golines 2 and 10x/gov/types/v1/genesis.goline 2x/gov/types/v1beta1/msgs.goline 2x/gov/types/v1/msgs.golines 2 and 10x/feegrant/msgs.goline 2x/feegrant/grant.goline 2x/feegrant/genesis.goline 2x/feegrant/filtered_fee.goline 2x/evidence/types/genesis.goline 2x/evidence/types/msgs.goline 2x/authz/msgs.golines 2 and 10x/authz/genesis.goline 2x/authz/authorization_grant.goline 2x/auth/types/query.goline 2x/auth/types/genesis.goline 2x/auth/types/account.goline 2x/auth/migrations/legacytx/stdtx.goline 2x/auth/migrations/legacytx/stdsignmsg.goline 2x/auth/migrations/legacytx/stdsign.goline 2types/result.golines 2 and 10types/tx/types.golines 2, 10, 18, 26, and 34types/tx/direct_aux.golines 2 and 10types/tx/signing/signature.golines 2 and 10testutil/testdata/grpc_query.golines 2 and 10testutil/testdata/animal.golines 2, 10, 18, and 26tests/e2e/authz/grpc.goline 2tests/integration/server/grpc/server_test.goline 2crypto/keys/multisig/multisig.goline 2crypto/keyring/record.goline 2crypto/keyring/legacy_info.goline 2codec/amino.golines 2, 10, 18, and 26codec/types/interface_registry.golines 2 and 10codec/types/types_test.golines 2, 10, and 18codec/proto_codec.golines 2 and 10codec/json.goline 2codec/any_test.golines 2 and 10client/grpc_query.goline 2client/grpc/cmtservice/service.goline 2Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all calls to `UnpackInterfaces` match the new signature. # Test: Search for the method usage. Expect: Only occurances of the new signature. rg --type go -A 5 $'UnpackInterfaces'Length of output: 48161
x/auth/types/account.go (3)
14-14: Import statement forgogoprotoanylooks good.The import statement is necessary for the changes made in this file.
20-20: Interface implementation change forBaseAccountlooks good.The interface implementation has been updated to use
gogoprotoany.UnpackInterfacesMessage.
136-139: Method signature change forUnpackInterfaceslooks good.The method signature has been updated to use
gogoprotoany.AnyUnpacker, and the logic remains intact.Ensure that all calls to this method are updated to match the new signature.
Verification successful
Method signature change for
UnpackInterfacesis correctly implemented.The method signature has been updated to use
gogoprotoany.AnyUnpacker, and all calls to this method across the codebase have been updated to match the new signature.
- Verified instances in:
x/staking/types/validator.gox/staking/types/msg.gox/group/types.gox/group/msgs.gox/group/genesis.gox/group/proposal.gox/gov/types/v1beta1/msgs.gox/gov/types/v1beta1/proposal.gox/gov/types/v1/proposal.gox/gov/types/v1/msgs.gox/feegrant/msgs.gox/feegrant/grant.gox/feegrant/genesis.gox/feegrant/filtered_fee.gox/evidence/types/msgs.gox/evidence/types/genesis.gox/authz/genesis.gox/authz/authorization_grant.gox/authz/msgs.gox/auth/types/genesis.gox/auth/types/query.gox/auth/types/account.gox/auth/migrations/legacytx/stdsign.gox/auth/migrations/legacytx/stdsignmsg.gotypes/result.gotypes/tx/msgs.gotypes/tx/types.gotypes/tx/direct_aux.gotypes/tx/signing/signature.gocodec/types/interface_registry.gocodec/types/types_test.gocodec/proto_codec.gocodec/json.gocodec/any_test.gocodec/amino.goclient/grpc_query.goclient/grpc/cmtservice/service.gocrypto/keyring/record.gocrypto/keyring/legacy_info.gocrypto/keys/multisig/multisig.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all calls to `UnpackInterfaces` match the new signature. # Test: Search for the method usage. Expect: Only occurances of the new signature. rg --type go -A 5 $'UnpackInterfaces'Length of output: 48161
codec/types/interface_registry.go (3)
10-10: LGTM! Import statement is correct.The import statement for
gogoprotoanyis correctly added.
21-22: LGTM! Function signature update is correct.The function signature has been correctly updated to use
gogoprotoany.AnyUnpacker.
33-33: LGTM! Interface modification is correct.The
gogoprotoany.AnyUnpackerhas been correctly added to theInterfaceRegistryinterface.x/authz/simulation/operations.go (2)
16-16: LGTM! Import statement is correct.The import statement for
gogoprotoanyis correctly added.
264-264: LGTM! Function signature update is correct.The function signature has been correctly updated to use
gogoprotoany.AnyUnpacker.x/staking/types/validator.go (3)
20-20: LGTM! Import statement is correct.The import statement for
gogoprotoanyis correctly added.
142-142: LGTM! Method signature update is correct.The method signature has been correctly updated to use
gogoprotoany.AnyUnpacker.
498-498: LGTM! Method signature update is correct.The method signature has been correctly updated to use
gogoprotoany.AnyUnpacker.x/group/types.go (4)
290-292: LGTM! The parameter type change is appropriate.The change of the
unpackerparameter type fromcodectypes.AnyUnpackertogogoprotoany.AnyUnpackeraligns with the PR objectives and does not affect the function's logic.
462-464: LGTM! The parameter type change is appropriate.The change of the
unpackerparameter type fromcodectypes.AnyUnpackertogogoprotoany.AnyUnpackeraligns with the PR objectives and does not affect the function's logic.
467-469: LGTM! The parameter type change is appropriate.The change of the
unpackerparameter type fromcodectypes.AnyUnpackertogogoprotoany.AnyUnpackeraligns with the PR objectives and does not affect the function's logic.
Line range hint
471-478:
LGTM! The parameter type change is appropriate.The change of the
unpackerparameter type fromcodectypes.AnyUnpackertogogoprotoany.AnyUnpackeraligns with the PR objectives and does not affect the function's logic.x/group/simulation/operations.go (1)
23-23: LGTM! The parameter type change is appropriate.The change of the
appCdcparameter type fromcdctypes.AnyUnpackertogogoprotoany.AnyUnpackeraligns with the PR objectives and does not affect the function's logic.Also applies to: 108-110
codec/codec.go
Outdated
| @@ -6,6 +6,7 @@ import ( | |||
| "google.golang.org/protobuf/reflect/protoreflect" | |||
|
|
|||
| "github.com/cosmos/cosmos-sdk/codec/types" | |||
| gogoprotoany "github.com/cosmos/gogoproto/types/any" | |||
There was a problem hiding this comment.
Fix import order.
The import statement for gogoprotoany should follow the import order conventions.
-import (
"github.com/cosmos/gogoproto/proto"
"google.golang.org/grpc/encoding"
"google.golang.org/protobuf/reflect/protoreflect"
"github.com/cosmos/cosmos-sdk/codec/types"
gogoprotoany "github.com/cosmos/gogoproto/types/any"
)
+import (
"github.com/cosmos/gogoproto/proto"
"google.golang.org/grpc/encoding"
"google.golang.org/protobuf/reflect/protoreflect"
"github.com/cosmos/cosmos-sdk/codec/types"
gogoprotoany "github.com/cosmos/gogoproto/types/any"
)Committable suggestion was skipped due to low confidence.
Tools
golangci-lint
9-9: File is not
gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order(gci)
x/auth/migrations/legacytx/stdtx.go
Outdated
| @@ -9,13 +9,14 @@ import ( | |||
| cryptotypes "github.com/cosmos/cosmos-sdk/crypto/types" | |||
| sdk "github.com/cosmos/cosmos-sdk/types" | |||
| "github.com/cosmos/cosmos-sdk/types/tx/signing" | |||
| gogoprotoany "github.com/cosmos/gogoproto/types/any" | |||
There was a problem hiding this comment.
Fix import order.
The import statement for gogoprotoany should follow the import order conventions.
-import (
errorsmod "cosmossdk.io/errors"
"cosmossdk.io/math"
"github.com/cosmos/cosmos-sdk/codec/legacy"
codectypes "github.com/cosmos/cosmos-sdk/codec/types"
cryptotypes "github.com/cosmos/cosmos-sdk/crypto/types"
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/cosmos/cosmos-sdk/types/tx/signing"
gogoprotoany "github.com/cosmos/gogoproto/types/any"
)
+import (
errorsmod "cosmossdk.io/errors"
"cosmossdk.io/math"
"github.com/cosmos/cosmos-sdk/codec/legacy"
codectypes "github.com/cosmos/cosmos-sdk/codec/types"
cryptotypes "github.com/cosmos/cosmos-sdk/crypto/types"
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/cosmos/cosmos-sdk/types/tx/signing"
gogoprotoany "github.com/cosmos/gogoproto/types/any"
)Committable suggestion was skipped due to low confidence.
crypto/keys/multisig/multisig.go
Outdated
| @@ -9,11 +9,12 @@ import ( | |||
| cryptotypes "github.com/cosmos/cosmos-sdk/crypto/types" | |||
| multisigtypes "github.com/cosmos/cosmos-sdk/crypto/types/multisig" | |||
| "github.com/cosmos/cosmos-sdk/types/tx/signing" | |||
| gogoprotoany "github.com/cosmos/gogoproto/types/any" | |||
There was a problem hiding this comment.
Fix import order.
The import statement for gogoprotoany should follow the import order conventions.
-import (
"fmt"
cmtcrypto "github.com/cometbft/cometbft/crypto"
"github.com/cosmos/cosmos-sdk/codec/types"
cryptotypes "github.com/cosmos/cosmos-sdk/crypto/types"
multisigtypes "github.com/cosmos/cosmos-sdk/crypto/types/multisig"
"github.com/cosmos/cosmos-sdk/types/tx/signing"
gogoprotoany "github.com/cosmos/gogoproto/types/any"
)
+import (
"fmt"
cmtcrypto "github.com/cometbft/cometbft/crypto"
"github.com/cosmos/cosmos-sdk/codec/types"
cryptotypes "github.com/cosmos/cosmos-sdk/crypto/types"
multisigtypes "github.com/cosmos/cosmos-sdk/crypto/types/multisig"
"github.com/cosmos/cosmos-sdk/types/tx/signing"
gogoprotoany "github.com/cosmos/gogoproto/types/any"
)Committable suggestion was skipped due to low confidence.
Tools
golangci-lint
12-12: File is not
gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order(gci)
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- UPGRADING.md (1 hunks)
Additional context used
Path-based instructions (1)
UPGRADING.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
Additional comments not posted (2)
UPGRADING.md (2)
173-174: Instructions are clear and correct.The instructions for updating the
buf.gen.gogo.yamlconfiguration files to reflect the new mapping forcodectypes.Anyare clear and detailed.
175-175: Instructions are clear and correct.The instructions for replacing the interfaces
AnyUnpackerandUnpackInterfacesMessagewith the new interfaces in thegit.luolix.top/cosmos/gogoproto/types/anypackage are clear and detailed.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (48)
- UPGRADING.md (1 hunks)
- client/grpc/cmtservice/service.go (3 hunks)
- client/keys/output_test.go (2 hunks)
- codec/codec.go (2 hunks)
- codec/types/interface_registry.go (3 hunks)
- crypto/keyring/legacy_info.go (2 hunks)
- crypto/keyring/record.go (2 hunks)
- crypto/keys/multisig/multisig.go (4 hunks)
- server/v2/cometbft/client/grpc/cmtservice/service.go (2 hunks)
- testutil/testdata/animal.go (4 hunks)
- testutil/testdata/grpc_query.go (2 hunks)
- types/result.go (3 hunks)
- types/tx/direct_aux.go (3 hunks)
- types/tx/ext.go (1 hunks)
- types/tx/msgs.go (2 hunks)
- types/tx/signing/signature.go (3 hunks)
- types/tx/types.go (6 hunks)
- x/auth/migrations/legacytx/stdsign.go (2 hunks)
- x/auth/migrations/legacytx/stdsignmsg.go (2 hunks)
- x/auth/migrations/legacytx/stdtx.go (3 hunks)
- x/auth/types/account.go (2 hunks)
- x/auth/types/genesis.go (2 hunks)
- x/auth/types/query.go (1 hunks)
- x/authz/authorization_grant.go (3 hunks)
- x/authz/genesis.go (3 hunks)
- x/authz/msgs.go (5 hunks)
- x/authz/simulation/operations.go (2 hunks)
- x/evidence/types/genesis.go (2 hunks)
- x/evidence/types/genesis_test.go (2 hunks)
- x/evidence/types/msgs.go (3 hunks)
- x/feegrant/filtered_fee.go (2 hunks)
- x/feegrant/genesis.go (2 hunks)
- x/feegrant/grant.go (2 hunks)
- x/feegrant/msgs.go (3 hunks)
- x/gov/types/v1/genesis.go (2 hunks)
- x/gov/types/v1/msgs.go (4 hunks)
- x/gov/types/v1/proposal.go (3 hunks)
- x/gov/types/v1beta1/genesis.go (2 hunks)
- x/gov/types/v1beta1/msgs.go (3 hunks)
- x/gov/types/v1beta1/proposal.go (3 hunks)
- x/group/genesis.go (2 hunks)
- x/group/msgs.go (6 hunks)
- x/group/proposal.go (2 hunks)
- x/group/simulation/operations.go (2 hunks)
- x/group/types.go (3 hunks)
- x/staking/types/genesis.go (2 hunks)
- x/staking/types/msg.go (4 hunks)
- x/staking/types/validator.go (3 hunks)
Files skipped from review due to trivial changes (2)
- x/feegrant/msgs.go
- x/staking/types/validator.go
Files skipped from review as they are similar to previous changes (39)
- UPGRADING.md
- client/grpc/cmtservice/service.go
- client/keys/output_test.go
- codec/codec.go
- crypto/keyring/legacy_info.go
- crypto/keyring/record.go
- crypto/keys/multisig/multisig.go
- testutil/testdata/animal.go
- testutil/testdata/grpc_query.go
- types/result.go
- types/tx/direct_aux.go
- types/tx/ext.go
- types/tx/msgs.go
- types/tx/signing/signature.go
- x/auth/migrations/legacytx/stdsign.go
- x/auth/migrations/legacytx/stdsignmsg.go
- x/auth/migrations/legacytx/stdtx.go
- x/auth/types/account.go
- x/auth/types/genesis.go
- x/auth/types/query.go
- x/authz/genesis.go
- x/authz/simulation/operations.go
- x/evidence/types/genesis.go
- x/evidence/types/genesis_test.go
- x/feegrant/filtered_fee.go
- x/feegrant/genesis.go
- x/feegrant/grant.go
- x/gov/types/v1/genesis.go
- x/gov/types/v1/msgs.go
- x/gov/types/v1/proposal.go
- x/gov/types/v1beta1/genesis.go
- x/gov/types/v1beta1/msgs.go
- x/gov/types/v1beta1/proposal.go
- x/group/genesis.go
- x/group/proposal.go
- x/group/simulation/operations.go
- x/group/types.go
- x/staking/types/genesis.go
- x/staking/types/msg.go
Additional context used
Path-based instructions (7)
x/evidence/types/msgs.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/authz/authorization_grant.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/authz/msgs.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.types/tx/types.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/group/msgs.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.server/v2/cometbft/client/grpc/cmtservice/service.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.codec/types/interface_registry.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (26)
x/evidence/types/msgs.go (3)
7-7: Import change approved.The addition of
gogoprotoanyis necessary for the changes made in this file.
16-17: Variable declarations updated to usegogoprotoany.UnpackInterfacesMessage.The changes are correct and align with the new import.
55-57: Function signature updated to usegogoprotoany.AnyUnpacker.The change is correct and aligns with the new import.
x/authz/authorization_grant.go (4)
7-7: Import change approved.The addition of
gogoprotoanyis necessary for the changes made in this file.
35-35: Variable declarations updated to usegogoprotoany.UnpackInterfacesMessage.The changes are correct and align with the new import.
38-40: Function signature updated to usegogoprotoany.AnyUnpacker.The change is correct and aligns with the new import.
25-27: Function body updated to usegogoprotoany.NewAnyWithCacheWithValue.The change is correct and aligns with the new import.
x/authz/msgs.go (5)
7-7: Import change approved.The addition of
gogoprotoanyis necessary for the changes made in this file.
19-20: Variable declarations updated to usegogoprotoany.UnpackInterfacesMessage.The changes are correct and align with the new import.
57-59: Function signature updated to usegogoprotoany.AnyUnpacker.The change is correct and aligns with the new import.
70-72: Function signature updated to usegogoprotoany.AnyUnpacker.The change is correct and aligns with the new import.
48-50: Function body updated to usegogoprotoany.NewAnyWithCacheWithValue.The change is correct and aligns with the new import.
types/tx/types.go (5)
Line range hint
180-188:
LGTM!The change to use
gogoprotoany.AnyUnpackerin theUnpackInterfacesfunction ofTxis consistent with the PR objectives.
Line range hint
195-206:
LGTM!The change to use
gogoprotoany.AnyUnpackerin theUnpackInterfacesfunction ofTxBodyis consistent with the PR objectives.
Line range hint
212-217:
LGTM!The change to use
gogoprotoany.AnyUnpackerin theUnpackInterfacesfunction ofAuthInfois consistent with the PR objectives.
223-225: LGTM!The change to use
gogoprotoany.AnyUnpackerin theUnpackInterfacesfunction ofSignerInfois consistent with the PR objectives.
23-23: LGTM!The change to use
gogoprotoany.UnpackInterfacesMessagefor interface implementation checks is consistent with the PR objectives.x/group/msgs.go (5)
87-89: LGTM!The change to use
gogoprotoany.AnyUnpackerin theUnpackInterfacesfunction ofMsgCreateGroupWithPolicyis consistent with the PR objectives.
130-132: LGTM!The change to use
gogoprotoany.AnyUnpackerin theUnpackInterfacesfunction ofMsgUpdateGroupPolicyDecisionPolicyis consistent with the PR objectives.
184-186: LGTM!The change to use
gogoprotoany.AnyUnpackerin theUnpackInterfacesfunction ofMsgCreateGroupPolicyis consistent with the PR objectives.
222-224: LGTM!The change to use
gogoprotoany.AnyUnpackerin theUnpackInterfacesfunction ofMsgSubmitProposalis consistent with the PR objectives.
31-33: LGTM!The change to use
gogoprotoany.UnpackInterfacesMessagefor interface implementation checks is consistent with the PR objectives.server/v2/cometbft/client/grpc/cmtservice/service.go (1)
Line range hint
135-141:
LGTM!The change to use
gogoprotoany.AnyUnpackerin theUnpackInterfacesfunction ofGetLatestValidatorSetResponseis consistent with the PR objectives.codec/types/interface_registry.go (3)
10-10: Import change approved.The import of
gogoprotoanyfromgit.luolix.top/cosmos/gogoproto/types/anyis necessary for the transition togogoprotoanyinterfaces.
21-22: Function signature change approved.The
UnpackInterfacesfunction has been updated to usegogoprotoany.AnyUnpacker, aligning with the new interface structure.
33-33: Interface change approved.The addition of
gogoprotoany.AnyUnpackerto theInterfaceRegistryinterface aligns with the transition togogoprotoany.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- server/v2/cometbft/client/grpc/cmtservice/service.go (3 hunks)
Additional context used
Path-based instructions (1)
server/v2/cometbft/client/grpc/cmtservice/service.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (3)
server/v2/cometbft/client/grpc/cmtservice/service.go (3)
12-12: Import statement addition approved.The import statement for
gogoprotoanyhas been correctly added.
26-27: Interface implementation declaration approved.The interface implementation declaration for
gogoprotoany.UnpackInterfacesMessagehas been correctly added.
Line range hint
134-143:
Function signature change approved.The parameter type for the
unpackerargument has been correctly changed fromcodectypes.AnyUnpackertogogoprotoany.AnyUnpacker.However, ensure that all function calls to
UnpackInterfacesmatch the new signature.Verification successful
Function signature change approved.
The parameter type for the
unpackerargument has been correctly changed fromcodectypes.AnyUnpackertogogoprotoany.AnyUnpacker. All instances ofUnpackInterfacesin the codebase match the new signature.
x/staking/types/genesis.gox/staking/types/validator.gox/staking/types/msg.gox/group/proposal.gox/group/types.gox/group/genesis.gox/group/msgs.gox/feegrant/msgs.gox/feegrant/genesis.gox/evidence/types/msgs.gox/evidence/types/genesis.gox/gov/types/v1beta1/proposal.gox/gov/types/v1beta1/msgs.gox/gov/types/v1/proposal.gox/gov/types/v1/msgs.gox/authz/genesis.gox/authz/msgs.gox/auth/types/query.gox/auth/types/account.gox/auth/types/genesis.gox/auth/migrations/legacytx/stdsignmsg.gox/auth/migrations/legacytx/stdtx.gox/auth/migrations/legacytx/stdsign.gocrypto/keyring/record.gocrypto/keyring/legacy_info.gocrypto/keys/multisig/multisig.goclient/grpc_query.goclient/grpc/cmtservice/service.gocodec/proto_codec.gocodec/json.gocodec/types/types_test.gocodec/any_test.gocodec/amino.gocodec/types/interface_registry.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `UnpackInterfaces` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'UnpackInterfaces'Length of output: 48163
| @@ -169,11 +170,6 @@ func packPubKeys(pubKeys []cryptotypes.PubKey) ([]*types.Any, error) { | |||
| return nil, err | |||
| } | |||
| anyPubKeys[i] = any | |||
|
|
|||
| // sets the compat.aminoBz value | |||
There was a problem hiding this comment.
Should this be backported to v50? If so let's extract it in another PR
* main: (48 commits) build(deps): add missing replaces and remove unnecessary ones (#21033) build(deps): Bump bufbuild/buf-setup-action from 1.34.0 to 1.35.0 (#21028) chore: fix some comments for struct field (#21027) chore(x): replace `fmt.Errorf` without parameters with `errors.New` (#21032) chore: fix errors reported by running `make lint` (#21015) ci: skip spelling check in go.mod/go.sum (#21021) chore(all)!: use gogoproto/any instead of codec/types/any (#21013) chore(server/v2/cometbft): ensure consistent dash-case in app.toml (#21018) docs(server): wrong function comments (#21017) refactor(storev2): update snapshot manager and migration manager tests (#20441) feat(server/v2/cometbft): config (#20989) refactor: set `help` as default target of Makefile (#21011) fix(simapp): duplicated import (#21014) chore(docs): fix functions and struct comments (#21010) fix(simapp/v2): panic with testnet init-files command (#21012) fix: make help won't work (#21005) fix: NewIntegrationApp does not write default genesis to state (#21006) chore(x/staking,x/upgrade): replace `fmt.Errorf` without parameters with `errors.New` (#21004) chore: prepare depinject 1.0.0 (#21001) docs: Fix typos in RFC Creation Process (#20998) ...
Description
This also removes completely the interfaces AnyUnpacker and UnpackInterfacesMessage, to avoid users using the wrong one.
We can leave codectypes.Any for now if we want, or we can decide to remove that too and use the one in gogoproto.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
gogoprotoanylibrary for improved interface unpacking across multiple modules.Bug Fixes
UnpackInterfacesMessageandAnyUnpackeracross various components.Documentation
Chores
gogoprotoanystandards in numerous files throughout the codebase.