feat(simapp/v2): Add store server to testnet init cmd #21076
Conversation
WalkthroughWalkthroughThe recent modifications involve updates to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (2)
- scripts/local-testnet.sh (1 hunks)
- simapp/v2/simdv2/cmd/testnet.go (2 hunks)
Additional context used
Path-based instructions (1)
simapp/v2/simdv2/cmd/testnet.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (3)
scripts/local-testnet.sh (1)
13-13: Confirm parameter name change.The parameter
--minimum-gas-priceshas been changed to--min-gas-prices. Ensure that this change aligns with the updated command-line interface of the underlying tool.simapp/v2/simdv2/cmd/testnet.go (2)
347-348: Integration ofstoreServer.A new
storeServerinstance is created usingstore.New[T]()and passed to theserverv2.NewServerconstructor. Ensure that this integration is consistent with the modular design and improves state management.
25-25: New dependency onstorepackage.The
storepackage has been imported. Ensure that this new dependency is necessary and correctly integrated.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (2)
- scripts/local-testnet.sh (1 hunks)
- simapp/v2/simdv2/cmd/testnet.go (2 hunks)
Files skipped from review due to trivial changes (1)
- scripts/local-testnet.sh
Additional context used
Path-based instructions (1)
simapp/v2/simdv2/cmd/testnet.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (3)
simapp/v2/simdv2/cmd/testnet.go (3)
25-25: Import statement forstore.The import statement for
storeis correct and necessary for the new functionality.
347-347: Creation ofstoreServer.The creation of
storeServerusingstore.New[T]()is correct. Ensure that thestorepackage is properly initialized and configured.
348-348: Integration ofstoreServerwithserverv2.NewServer.The integration of
storeServerwithserverv2.NewServeris correct and enhances the server's functionality. Ensure that thestoreServeris properly utilized within theserverv2package.
julienrbrt
changed the title
* main: feat(log): remove core dependency and update core interface to be dependency free (#21045) chore: fix some comments (#21085) feat: simulate nested messages (#20291) chore(network): remove `DefaultConfigWithAppConfigWithQueryGasLimit` (#21055) fix(runtime): remove `appv1alpha1.Config` from runtime (#21042) feat(simapp/v2): Add store server to testnet init cmd (#21076) chore(indexer/postgres): update to changes on main (#21077) feat(schema/appdata): async listener mux'ing (#20879) ci: Use large box for 052 branch sims on CI (#21067) chore(all): replace all `fmt.Errorf` without paramters with `errors.New` (#21068)
Description
Closes: #XXXX
Missing
storeserver intestnet-initsince #20736 was mergedAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Bug Fixes
Documentation