build(deps): Bump actions/xxx-artifact from v3 to v4 #22468
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request includes updates to the GitHub Actions workflows, specifically upgrading the versions of several actions used in the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
This reverts commit 06f1c24.
|
We probably need to do that to all version we maintain. I'll let dependabot do it for v0.52 as it is pretty similar. |
julienrbrt
added
the
backport/v0.52.x
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/test.yml (1)
77-77: Optimize the shell script by removing unnecessary cat.Consider replacing the
catcommand with direct input redirection for better efficiency:- cat pkgs.txt.part.${{ matrix.part }} | xargs go test -mod=readonly -race -timeout 30m -coverprofile=${{ matrix.part }}profile.out -covermode=atomic -tags='ledger test_ledger_mock' + xargs go test -mod=readonly -race -timeout 30m -coverprofile=${{ matrix.part }}profile.out -covermode=atomic -tags='ledger test_ledger_mock' < pkgs.txt.part.${{ matrix.part }}🧰 Tools
🪛 actionlint
77-77: shellcheck reported issue in this script: SC2002:style:1:5: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead
(shellcheck)
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/test.yml(5 hunks)
🧰 Additional context used
🪛 actionlint
.github/workflows/test.yml
77-77: shellcheck reported issue in this script: SC2002:style:1:5: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead
(shellcheck)
🔇 Additional comments (2)
.github/workflows/test.yml (2)
29-33: LGTM: Artifact action upgrades are properly implemented.
The upgrade of actions/upload-artifact and actions/download-artifact from v3 to v4 is:
- Necessary due to v3 deprecation in December 2024
- Safe as the breaking changes in v4 don't impact the current implementation
- Consistently applied across all jobs
Also applies to: 37-41, 79-82, 110-113, 149-152, 170-190
Line range hint 1-1024: LGTM: Workflow structure is well-designed.
The workflow demonstrates good practices:
- Clear job dependencies and organization
- Efficient use of conditional execution
- Comprehensive test coverage across modules
(cherry picked from commit 4e24090)
#22470) Co-authored-by: auricom <27022259+auricom@users.noreply.github.com>
* main: (31 commits) docs: update links for https security protocol (#22514) build(deps): Bump github.com/bytedance/sonic from 1.12.3 to 1.12.4 in /log (#22513) feat(x/protocolpool)!: allow any coins in continuous funds (#21916) docs: Update protobuf tx signing message format outer link (#22510) test(accounts): fix integration tests (#22418) chore(x): fix some typos in comment (#22508) build(deps): Bump cosmossdk.io/log from 1.4.1 to 1.5.0 (#22487) build(deps): Bump cosmossdk.io/core from 1.0.0-alpha.5 to 1.0.0-alpha.6 (#22502) build(deps): Bump golang.org/x/crypto from 0.28.0 to 0.29.0 (#22480) docs(adr75): server v2 (#21069) fix(server/v2): improve server stop (#22455) chore: prepare core changelog (#22495) refactor(store/v2): simplify genesis flow (#22435) build(deps): Bump google.golang.org/grpc from 1.67.1 to 1.68.0 (#22486) build(deps): Bump golang.org/x/sync from 0.8.0 to 0.9.0 (#22482) feat(x/circuit): Allow msg Reset with empty msgURL (#22459) build(deps): Bump actions/xxx-artifact from v3 to v4 (#22468) feat(stf/branch): simplify merged iterator (#22131) refactor(log): disable coloring in testing logger (#22466) chore(x/tx): update changelog to alpha.2 (#22465) ...
Description
Closes: #22447
The breaking changes between v3 and v4 do not affect us as we did not use the mutable nature on artifacts.
https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md
Forced the execution of download steps on this workflow execution : https://github.com/cosmos/cosmos-sdk/actions/runs/11723916073?pr=22468
The regression observed in 2023 does not seems to occur as of now.
#18752
#18751
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit