Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R]: Vesting Account(s) Implementation #2694

Merged
merged 84 commits into from
Jan 14, 2019
Merged

[R4R]: Vesting Account(s) Implementation #2694

merged 84 commits into from
Jan 14, 2019

Commits on Nov 5, 2018

  1. Implement initial vesting account interface

    Aleksandr Bezobchuk committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    be182d2 View commit details
    Browse the repository at this point in the history

  2. Add vesting account types

    Aleksandr Bezobchuk committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    043f90a View commit details
    Browse the repository at this point in the history

  3. Update vesting spec per impl updates

    Aleksandr Bezobchuk committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    d012405 View commit details
    Browse the repository at this point in the history

  4. Implement vesting/vested coins for cont. vesting account

    Aleksandr Bezobchuk committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    4fbd311 View commit details
    Browse the repository at this point in the history

  5. Implement unit tests for cont. vesting account

    Aleksandr Bezobchuk committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    ba7e14c View commit details
    Browse the repository at this point in the history

  6. Implement SpendableCoins for cont. vesting account

    Aleksandr Bezobchuk committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    541608d View commit details
    Browse the repository at this point in the history

  7. Update spec variables and parameters

    Aleksandr Bezobchuk committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    e21acac View commit details
    Browse the repository at this point in the history

  8. Implement max int and max uint

    Aleksandr Bezobchuk committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    75a6673 View commit details
    Browse the repository at this point in the history

  9. Track delegation cont. vesting account implementation

    Aleksandr Bezobchuk committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    149a1b6 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2018

  1. Further spec revisions

    Aleksandr Bezobchuk committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    5c55471 View commit details
    Browse the repository at this point in the history

  2. Add godoc for TrackDelegation and fix comments

    Aleksandr Bezobchuk committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    7d78e50 View commit details
    Browse the repository at this point in the history

  3. Implement TrackUndelegation for cont. vesting account

    Aleksandr Bezobchuk committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    3a0212d View commit details
    Browse the repository at this point in the history

  4. Spec interface update

    Aleksandr Bezobchuk committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    950e78c View commit details
    Browse the repository at this point in the history

  5. Assert cont. vesting account interface

    Aleksandr Bezobchuk committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    c33758f View commit details
    Browse the repository at this point in the history

  6. Fix linting errors

    Aleksandr Bezobchuk committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    5b7937a View commit details
    Browse the repository at this point in the history

  7. Implement del. vesting account constructor and spendable coins

    Aleksandr Bezobchuk committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    9493040 View commit details
    Browse the repository at this point in the history

  8. Implement GetVestingCoins for del. vesting account

    Aleksandr Bezobchuk committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    be4aaeb View commit details
    Browse the repository at this point in the history

  9. Implement SpendableCoins for del. vesting account

    Aleksandr Bezobchuk committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    5fb0d1d View commit details
    Browse the repository at this point in the history

  10. Update spec by simplifying del. vesting account

    Aleksandr Bezobchuk committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    5f0229e View commit details
    Browse the repository at this point in the history

  11. Cleanup the spec

    Aleksandr Bezobchuk committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    4b5407c View commit details
    Browse the repository at this point in the history

  12. DRY-up vesting account implementations

    Aleksandr Bezobchuk committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    fd93ff7 View commit details
    Browse the repository at this point in the history

  13. Implement TestTrackUndelegationDelVestingAcc

    Aleksandr Bezobchuk committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    73b6b97 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2018

  1. Merge branch 'develop' into bez/vesting-impl-2

    Aleksandr Bezobchuk committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    7771e36 View commit details
    Browse the repository at this point in the history

  2. Make all vesting account fields public

    Aleksandr Bezobchuk committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    fc7f71c View commit details
    Browse the repository at this point in the history

  3. Update bank keeper SendCoins to handle vesting accounts

    Aleksandr Bezobchuk committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    cf74309 View commit details
    Browse the repository at this point in the history

  4. Implement receive bank keeper test for vesting accounts

    Aleksandr Bezobchuk committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    4417381 View commit details
    Browse the repository at this point in the history

  5. Cleanup SendCoins pseudo-code in vesting spec

    Aleksandr Bezobchuk committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    f241a4b View commit details
    Browse the repository at this point in the history

  6. Cleanup DelegateCoins pseudo-code in the vesting spec

    Aleksandr Bezobchuk committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    97ba3d3 View commit details
    Browse the repository at this point in the history

  7. Add XXX on setting coins directly in track (un)delegation

    Aleksandr Bezobchuk committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    5de1965 View commit details
    Browse the repository at this point in the history

  8. Fix value updates in account test

    Aleksandr Bezobchuk committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    a85d199 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2018

  1. Implement bank keeper's DelegateCoins

    Aleksandr Bezobchuk committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    6bb0ddd View commit details
    Browse the repository at this point in the history

  2. Implement the bank keeper's UndelegateCoins

    Aleksandr Bezobchuk committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    06ec3e5 View commit details
    Browse the repository at this point in the history

  3. Fix vesting account persistence bug

    Aleksandr Bezobchuk committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    ce7ac38 View commit details
    Browse the repository at this point in the history

  4. Check setCoins error

    Aleksandr Bezobchuk committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    999c9fe View commit details
    Browse the repository at this point in the history

  5. Remove DeductFees as subtract coins can be directly used

    Aleksandr Bezobchuk committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    82a0230 View commit details
    Browse the repository at this point in the history

  6. Update delegation to use new bank keeper API

    Aleksandr Bezobchuk committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    49cf30b View commit details
    Browse the repository at this point in the history

  7. Add pending log entry

    Aleksandr Bezobchuk committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    50bc71e View commit details
    Browse the repository at this point in the history

  8. Update ante handler to deduct fees for vesting accs

    Aleksandr Bezobchuk committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    56137f5 View commit details
    Browse the repository at this point in the history

  9. Minor godoc update for deductFees

    Aleksandr Bezobchuk committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    d005b3c View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2018

  1. Merge branch 'develop' into bez/vesting-impl-2

    Aleksandr Bezobchuk committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    7902662 View commit details
    Browse the repository at this point in the history

  2. Update delegate/undelegate tags

    Aleksandr Bezobchuk committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    1ac53f8 View commit details
    Browse the repository at this point in the history

  3. Add clarification to discrete vesting accounts in spec

    Aleksandr Bezobchuk committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    ada577f View commit details
    Browse the repository at this point in the history

  4. Add defensive checks to delegation/undelegation amounts

    Aleksandr Bezobchuk committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    47d804a View commit details
    Browse the repository at this point in the history

  5. Update TestTrackDelegationContVestingAcc to test order

    Aleksandr Bezobchuk committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    03bf9b7 View commit details
    Browse the repository at this point in the history

  6. Improve performance of GetVestedCoins

    Aleksandr Bezobchuk committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    407e710 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2018

  1. Update delegate/undelegate coins tag(s)

    Aleksandr Bezobchuk committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    eac516c View commit details
    Browse the repository at this point in the history

  2. Improve performance of spendableCoins

    Aleksandr Bezobchuk committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    ed8cc80 View commit details
    Browse the repository at this point in the history

  3. Update spendableCoins godoc

    Aleksandr Bezobchuk committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    31c65fa View commit details
    Browse the repository at this point in the history

  4. Further comment/godoc updates

    Aleksandr Bezobchuk committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    579b120 View commit details
    Browse the repository at this point in the history

  5. Implement AddCoin and SubCoin

    Aleksandr Bezobchuk committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    d4016ab View commit details
    Browse the repository at this point in the history

  6. Update coins add/sub coin and vesting to use the APIs

    Aleksandr Bezobchuk committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    78dff94 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into bez/vesting-impl-2

    Aleksandr Bezobchuk committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    68b6080 View commit details
    Browse the repository at this point in the history

  8. Fix tag values (type)

    Aleksandr Bezobchuk committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    ad56f22 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2018

  1. Update Delegate return variable on error

    Aleksandr Bezobchuk committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    0350362 View commit details
    Browse the repository at this point in the history

  2. Fix spec TOC

    Aleksandr Bezobchuk committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    40f5768 View commit details
    Browse the repository at this point in the history

  3. Update SubCoinByDenom godoc

    Aleksandr Bezobchuk committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    ef0a9da View commit details
    Browse the repository at this point in the history

  4. Update AddCoinByDenom godoc

    Aleksandr Bezobchuk committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    1fe37b9 View commit details
    Browse the repository at this point in the history

  5. Update tags

    Aleksandr Bezobchuk committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    129114b View commit details
    Browse the repository at this point in the history

  6. Remove XXX comments

    Aleksandr Bezobchuk committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    3e4513f View commit details
    Browse the repository at this point in the history

  7. Improve runtime perf. of track del/undel

    Aleksandr Bezobchuk committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    cfef5bb View commit details
    Browse the repository at this point in the history

  8. DRY-up subtractCoins

    Aleksandr Bezobchuk committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    ea4792f View commit details
    Browse the repository at this point in the history

  9. Update Add/SubCoinByDenom to work on a copy

    Aleksandr Bezobchuk committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    d1faf4f View commit details
    Browse the repository at this point in the history

  10. Update vesting accounts API

    Aleksandr Bezobchuk committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    21fa5b4 View commit details
    Browse the repository at this point in the history

  11. DRY-up delegation/undelegation in bank keeper

    Aleksandr Bezobchuk committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    3d4bee2 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2018

  1. Merge branch 'develop' into bez/vesting-impl-2

    Aleksandr Bezobchuk committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    d767908 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2018

  1. Merge branch 'develop' into bez/vesting-impl-2

    Aleksandr Bezobchuk committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    f96c9b6 View commit details
    Browse the repository at this point in the history

  2. Update vesting spec accounts section

    Aleksandr Bezobchuk committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    511dc68 View commit details
    Browse the repository at this point in the history

  3. Cleanup deductFees

    Aleksandr Bezobchuk committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    653434c View commit details
    Browse the repository at this point in the history

  4. Remove Coin#IsNotNegative

    Aleksandr Bezobchuk committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    5b969c7 View commit details
    Browse the repository at this point in the history

  5. Modify base account in TrackDelegation/TrackUndelegation

    Aleksandr Bezobchuk committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    19991a4 View commit details
    Browse the repository at this point in the history

  6. Dont return coins on TrackUndelegation/TrackDelegation

    Aleksandr Bezobchuk committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    01cb811 View commit details
    Browse the repository at this point in the history

  7. Add TODOs for binary search

    Aleksandr Bezobchuk committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    96c4b5b View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2018

  1. Panic during add/sub coin by denom when denom is not found

    Aleksandr Bezobchuk committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    31e208a View commit details
    Browse the repository at this point in the history

  2. Update godoc and unit tests

    Aleksandr Bezobchuk committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    b31f288 View commit details
    Browse the repository at this point in the history

  3. Fix linting

    Aleksandr Bezobchuk committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    211ab22 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2018

  1. Merge branch 'develop' into bez/vesting-impl-2

    Aleksandr Bezobchuk committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    7e84b4e View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2019

  1. Merge branch 'develop' into bez/vesting-impl-2

    Aleksandr Bezobchuk committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    1394c79 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2019

  1. Update AddCoinByDenom to not panic

    Aleksandr Bezobchuk committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    fae2877 View commit details
    Browse the repository at this point in the history

  2. Remove TrackDelegation and TrackUndelegation from Account interface

    Aleksandr Bezobchuk committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    0b6039f View commit details
    Browse the repository at this point in the history

  3. Remove TrackDelegation and TrackUndelegation from Account interface

    Aleksandr Bezobchuk committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    cf8b5c7 View commit details
    Browse the repository at this point in the history

  4. Revise vesting spec 

    - Fix any glaring grammatical errors
- Update to reflect latest PR updates
    Aleksandr Bezobchuk committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    4f70eec View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2019

  1. Do not add coin to empty set on Add/SubCoinsByDenom

    Aleksandr Bezobchuk committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    39b0387 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into bez/vesting-impl-2

    Aleksandr Bezobchuk committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    c3515af View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2019

  1. Remove Add/SubCoinsByDenom in favor of Plus/Minus

    Aleksandr Bezobchuk committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    ab385c1 View commit details
    Browse the repository at this point in the history