Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R]: Vesting Account(s) Implementation #2694

Merged
merged 84 commits into from
Jan 14, 2019
Merged

[R4R]: Vesting Account(s) Implementation #2694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
84 commits
Select commit Hold shift + click to select a range
be182d2
Implement initial vesting account interface
Nov 5, 2018
043f90a
Add vesting account types
Nov 5, 2018
d012405
Update vesting spec per impl updates
Nov 5, 2018
4fbd311
Implement vesting/vested coins for cont. vesting account
Nov 5, 2018
ba7e14c
Implement unit tests for cont. vesting account
Nov 5, 2018
541608d
Implement SpendableCoins for cont. vesting account
Nov 5, 2018
e21acac
Update spec variables and parameters
Nov 5, 2018
75a6673
Implement max int and max uint
Nov 5, 2018
149a1b6
Track delegation cont. vesting account implementation
Nov 5, 2018
5c55471
Further spec revisions
Nov 6, 2018
7d78e50
Add godoc for TrackDelegation and fix comments
Nov 6, 2018
3a0212d
Implement TrackUndelegation for cont. vesting account
Nov 6, 2018
950e78c
Spec interface update
Nov 6, 2018
c33758f
Assert cont. vesting account interface
Nov 6, 2018
5b7937a
Fix linting errors
Nov 6, 2018
9493040
Implement del. vesting account constructor and spendable coins
Nov 6, 2018
be4aaeb
Implement GetVestingCoins for del. vesting account
Nov 6, 2018
5fb0d1d
Implement SpendableCoins for del. vesting account
Nov 6, 2018
5f0229e
Update spec by simplifying del. vesting account
Nov 6, 2018
4b5407c
Cleanup the spec
Nov 6, 2018
fd93ff7
DRY-up vesting account implementations
Nov 6, 2018
73b6b97
Implement TestTrackUndelegationDelVestingAcc
Nov 6, 2018
7771e36
Merge branch 'develop' into bez/vesting-impl-2
Nov 7, 2018
fc7f71c
Make all vesting account fields public
Nov 7, 2018
cf74309
Update bank keeper SendCoins to handle vesting accounts
Nov 7, 2018
4417381
Implement receive bank keeper test for vesting accounts
Nov 7, 2018
f241a4b
Cleanup SendCoins pseudo-code in vesting spec
Nov 7, 2018
97ba3d3
Cleanup DelegateCoins pseudo-code in the vesting spec
Nov 7, 2018
5de1965
Add XXX on setting coins directly in track (un)delegation
Nov 7, 2018
a85d199
Fix value updates in account test
Nov 7, 2018
6bb0ddd
Implement bank keeper's DelegateCoins
Nov 8, 2018
06ec3e5
Implement the bank keeper's UndelegateCoins
Nov 8, 2018
ce7ac38
Fix vesting account persistence bug
Nov 8, 2018
999c9fe
Check setCoins error
Nov 8, 2018
82a0230
Remove DeductFees as subtract coins can be directly used
Nov 8, 2018
49cf30b
Update delegation to use new bank keeper API
Nov 8, 2018
50bc71e
Add pending log entry
Nov 8, 2018
56137f5
Update ante handler to deduct fees for vesting accs
Nov 8, 2018
d005b3c
Minor godoc update for deductFees
Nov 8, 2018
7902662
Merge branch 'develop' into bez/vesting-impl-2
Nov 26, 2018
1ac53f8
Update delegate/undelegate tags
Nov 26, 2018
ada577f
Add clarification to discrete vesting accounts in spec
Nov 26, 2018
47d804a
Add defensive checks to delegation/undelegation amounts
Nov 26, 2018
03bf9b7
Update TestTrackDelegationContVestingAcc to test order
Nov 26, 2018
407e710
Improve performance of GetVestedCoins
Nov 26, 2018
eac516c
Update delegate/undelegate coins tag(s)
Nov 27, 2018
ed8cc80
Improve performance of spendableCoins
Nov 27, 2018
31c65fa
Update spendableCoins godoc
Nov 27, 2018
579b120
Further comment/godoc updates
Nov 27, 2018
d4016ab
Implement AddCoin and SubCoin
Nov 27, 2018
78dff94
Update coins add/sub coin and vesting to use the APIs
Nov 27, 2018
68b6080
Merge branch 'develop' into bez/vesting-impl-2
Nov 27, 2018
ad56f22
Fix tag values (type)
Nov 27, 2018
0350362
Update Delegate return variable on error
Nov 28, 2018
40f5768
Fix spec TOC
Nov 28, 2018
ef0a9da
Update SubCoinByDenom godoc
Nov 28, 2018
1fe37b9
Update AddCoinByDenom godoc
Nov 28, 2018
129114b
Update tags
Nov 28, 2018
3e4513f
Remove XXX comments
Nov 28, 2018
cfef5bb
Improve runtime perf. of track del/undel
Nov 28, 2018
ea4792f
DRY-up subtractCoins
Nov 28, 2018
d1faf4f
Update Add/SubCoinByDenom to work on a copy
Nov 28, 2018
21fa5b4
Update vesting accounts API
Nov 28, 2018
3d4bee2
DRY-up delegation/undelegation in bank keeper
Nov 28, 2018
d767908
Merge branch 'develop' into bez/vesting-impl-2
Nov 29, 2018
f96c9b6
Merge branch 'develop' into bez/vesting-impl-2
Dec 5, 2018
511dc68
Update vesting spec accounts section
Dec 5, 2018
653434c
Cleanup deductFees
Dec 5, 2018
5b969c7
Remove Coin#IsNotNegative
Dec 5, 2018
19991a4
Modify base account in TrackDelegation/TrackUndelegation
Dec 5, 2018
01cb811
Dont return coins on TrackUndelegation/TrackDelegation
Dec 5, 2018
96c4b5b
Add TODOs for binary search
Dec 5, 2018
31e208a
Panic during add/sub coin by denom when denom is not found
Dec 6, 2018
b31f288
Update godoc and unit tests
Dec 6, 2018
211ab22
Fix linting
Dec 6, 2018
7e84b4e
Merge branch 'develop' into bez/vesting-impl-2
Dec 11, 2018
1394c79
Merge branch 'develop' into bez/vesting-impl-2
Jan 3, 2019
fae2877
Update AddCoinByDenom to not panic
Jan 10, 2019
0b6039f
Remove TrackDelegation and TrackUndelegation from Account interface
Jan 10, 2019
cf8b5c7
Remove TrackDelegation and TrackUndelegation from Account interface
Jan 10, 2019
4f70eec
Revise vesting spec
Jan 10, 2019
39b0387
Do not add coin to empty set on Add/SubCoinsByDenom
Jan 11, 2019
c3515af
Merge branch 'develop' into bez/vesting-impl-2
Jan 11, 2019
ab385c1
Remove Add/SubCoinsByDenom in favor of Plus/Minus
Jan 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions PENDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ FEATURES
* [\#2182] [x/staking] Added querier for querying a single redelegation

* SDK
* \#2694 Vesting account implementation.
* \#2996 Update the `AccountKeeper` to contain params used in the context of
the ante handler.
* [\#3179](https://github.com/cosmos/cosmos-sdk/pull/3179) New CodeNoSignatures error code.
Expand Down
Loading