Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto: migrate x/evidence to hybridcodec #5634

Merged
merged 97 commits into from
Feb 24, 2020
Merged

proto: migrate x/evidence to hybridcodec #5634

merged 97 commits into from
Feb 24, 2020

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Feb 11, 2020

this pr includes mint module as it is smaller

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez marked this pull request as ready for review February 24, 2020 15:01
@alexanderbez alexanderbez added R4R and removed WIP labels Feb 24, 2020
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🎉

@alexanderbez alexanderbez merged commit f7486b9 into master Feb 24, 2020
@alexanderbez alexanderbez deleted the proto/evidence branch February 24, 2020 16:05
@fedekunze
Copy link
Collaborator

why was the evidence msg removed?

@tac0turtle
Copy link
Member Author

tac0turtle commented Feb 26, 2020

needs to be lifted to the app level so you will find the messge here: https://github.com/cosmos/cosmos-sdk/blob/master/simapp/codec/codec.proto

since it is a oneof that can be extended we need the app to define it, the samething will be done for accounts and gov proposal msgs

@alexanderbez
Copy link
Contributor

Read the ADR @fedekunze 😉

larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/evidence C:x/mint T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants