Add protobuf Tx unit tests #6614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6614 +/- ##
==========================================
+ Coverage 60.26% 61.42% +1.15%
==========================================
Files 390 509 +119
Lines 25331 31457 +6126
==========================================
+ Hits 15266 19321 +4055
- Misses 8897 10637 +1740
- Partials 1168 1499 +331 |
|
What is the status here? Since #6423 and #6571 have been closed, this seems the last blocker to begin updating clients to the new "stargate" API. It doesn't seem there has been movement in almost 2 weeks. I assume it is blocked by some of the other parts of #6213 I'd be happy for a quick update and any ETA on this to help with planning |
|
@ethanfrey This is blocked on #6717 and #6734. I think those are pretty close. I will pick this up again after those are merged in. |
aaronc
requested review from
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
sahith-narahari
approved these changes
Jul 23, 2020
|
Nice |
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* Enable proto tx by default and add test_amino build flag. * Enable proto TxDecoder * update makefile * fix conflicts * Revert AminoCodec change * Make test-unit-amino default for now * Make test-unit-amino default for now Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: sahith-narahari <sahithnarahari@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #6213
This PR adds separate test configurations for protobuf and amino transactions. Currently amino transactions will remain as the default for tests, but that will switch after protobuf transactions are fully tested. This is needed to finish testing on #6717 and #6734. Once those are merged and
make test-unit-protopasses, that will be switched to the default test config.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes