init: Implement ADR 032 typed events #7564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Codecov Report
@@ Coverage Diff @@
## master #7564 +/- ##
==========================================
+ Coverage 54.11% 54.12% +0.01%
==========================================
Files 611 611
Lines 38571 38620 +49
==========================================
+ Hits 20871 20902 +31
- Misses 15573 15582 +9
- Partials 2127 2136 +9 |
anilcse
changed the title
anilcse
changed the title
anilcse
changed the title
akhilkumarpilli
requested review from
aaronc,
alessio and
alexanderbez
as code owners
amaury1093
reviewed
Oct 26, 2020
types/events_test.go
Outdated
| coin2 := sdk.NewCoin("fakedenom2", sdk.NewInt(1999999)) | ||
|
|
||
| s.Require().NoError(em.EmitTypedEvents(&coin1)) | ||
| s.Require().NoError(em.EmitTypedEvent(&coin2)) |
There was a problem hiding this comment.
This didn't cross my mind while reading the ADR, but does now. It seems weird that we can send an event that is a Coin.
Maybe we should create some convention, like the type name should be Event... or Msg...Response? (can be for another PR of course)
| // TypedEventToEvent takes typed event and converts to Event object | ||
| func TypedEventToEvent(tev proto.Message) (Event, error) { | ||
| evtType := proto.MessageName(tev) | ||
| evtJSON, err := codec.ProtoMarshalJSON(tev, nil) |
There was a problem hiding this comment.
I think that the nil argument won't work if tev contains an Any... or maybe it will. Just to be sure, would you mind adding a test with Any in TestEventManagerTypedEvents?
jackzampolin
approved these changes
Oct 27, 2020
amaury1093
added
the
A:automerge
clevinson
pushed a commit
that referenced
this pull request
Oct 29, 2020
* Add EmitTypedEvent in events * Add parseTypedEvent method * Use jsonpb * Modify unmarshal proto in events * Add a test for typed events * Fix reflect issue in parseTypedEvent * Modify event tests and add comments * Add EmitTypedEvents and refactor other methods * Fix golangci-lint issues * Update ProtoMarshalJSON params * Address PR comments Co-authored-by: anilCSE <anil@vitwit.com> Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement
EmitTypedEvent,EmitTypedEventsandParseTypedEventfunctions.ref: #7563
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes