Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backports]: v0.40.0-rc2 Cherry-picks #7734

Closed
wants to merge 28 commits into from
Closed

[backports]: v0.40.0-rc2 Cherry-picks #7734

wants to merge 28 commits into from

Conversation

clevinson
Copy link
Contributor

@clevinson clevinson commented Oct 29, 2020 •
edited by aaronc
Loading

Description

Backports included in this PR:

Current issues / outstanding PRs that we are waiting on for RC2:

Tracking for hopeful inclusing in RC2, but nonblocking:

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

yihuang and others added 28 commits October 29, 2020 12:10
@yihuang @alessio @clevinson
shutdown gracefully without os.Exit (#7480)
0fc0b34 
* shutdown gracefully without os.Exit

* Update server/util.go

Co-authored-by: Alessio Treglia <quadrispro@ubuntu.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
@colin-axner @fedekunze
@cwgoes @mergify @clevinson
Remove ClientType func and update consensus state path (#7573)
1db641d 
* update paths and remove unused func

* fix bug

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@robert-zaremba @blushi
@amaury1093 @clevinson
Refactor x/staking Validation and Delegation tests based on MsgCreate…
95f4fc8 
…Validator.Pubkey type change. (#7526)

* testing: refactore Validation and Delegation handling of x/staking

This Changeset introduces set of improvements for writing tests.

The idea is to create a testing subpackage which will provide functions
to make tests more dev-friendly and wrap higher level use-cases.
Here is a show-up of of creating a service for staking module
for tests.

This PR also changes the `x/staking/types.MsgCreateValidator.Pubkey` from string
to types.Any. This change motivated the other change to show the pattern I'm describing here.

* add validator checks

* type change fixes

* use deprecated

* adding test slashing

* new network comment update

* working on tests

* Fix TestMsgPkDecode test

* Add UnpackInterfaces to MsgCreateValidator

* Fix tests

* Convert bech32 pubkey to proto

* Fix test

* fix v039/migrate_test/TestMigrate

* fix tests

* testslashing: rename Service to Helper

* file rename

* update TestMsgDecode

Co-authored-by: blushi <marie.gauthier63@gmail.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
@bluele @colin-axner @clevinson
fix sequence checks in solomachine (#7586)
2bc7fa8 
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
@yun-yeo @alexanderbez
@mergify @clevinson
Bugfix gov votes querier to use votes params (#7589)
eab96fe 
* bugfix gov votes querier to use votes params

* move partially used statement to the proper block

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@aaronc @clevinson
Use InterfaceRegistry as AnyResolver for grpc-gateway (#7646)
64c8cf7
@robert-zaremba @clevinson
@amaury1093 @blushi
Use any as validator pubkey (#7597)
d7dded3 
* protobuf pubkey type update

* wip2

* wip3

* solving types.NewValidator issues

* remove bech32 from validator type assignment

* update Validator interface

* Changelog update

* wip4

* update genutil

* fix simapp & x/ibc/testing tests

* update staking

* changelog update

* fix import cycle in tests

* fix amino panic on TestValidatorMarshalUnmarshalJSON

* fix TestValidatorMarshalUnmarshalJSON consensus_pubkey check

* Add UnpackInterfaces to HistoricalInfo

* fix TestHistoricalInfo

* update todos

* fix: Expecting ed25519.PubKey to implement proto.Message

* fix linter issues

* Fix migrate test

* Update CHANGELOG.md

Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>

* review comments

* cosmetic changes

* add UnpackInterfaces got GenesisRandomized test

* Validator.Equal reuses Validator.MinEqual

* fix test

* use Validator.Equal in tests

* Fix staking simulation TestRandomizedGenState

* Remove TODO

* use HistoricalInfo.Equal

* use proto.Equal

* rename Validator.GetConsPubKey to TmConsPubKey

* prefer require.Equal over reflect.DeepEqual

* SetHistoricalInfo using a pointer

* Fix TestQueryDelegation test

* Fix TestQueryValidators test

* Fix TestSimulateMsgUnjail test

* experiement with LegacyAmino instances

* Register codecs in all simapp tests

* Fix cli_test compilation problems

* fix typo sdk -> std

* fix typo

* fix TestPlanStringer

* Rename to MakeEncodingConfig

* Remove RegisterCodecsTests

* Use gRPC in GetCmdQueryValidators

* Empty status

* fix info log check

* linter fixes

* rename simapparams to simappparams

* Update simapp/test_helpers.go

Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>

* comments updates

* use valAddr1 instead of sdk.ValAddress(pk1.Address().Bytes())

Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
@colin-axner @clevinson
Fix IBC Query cmds (#7648)
d488a18 
* fix query

* update comment
@colin-axner @fedekunze @clevinson
IBC: panic on GetSignBytes and remove SubModuleCdc (#7645)
c0ae5c9 
* panic on GetSignBytes and remove SubModuleCdc where possible

* fix build

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
@aaronc @clevinson
Return an unsigned tx in legacy GET /tx endpoint when signature conve…
e715a91 
…rsion fails (#7649)

* Return an unsigned tx in legacy GET /tx endpoint when signature conversion fails

* Add test

* add comment

* add comment

* add comment
@AdityaSripal @cwgoes
@mergify @clevinson
Create separate Write-Ack Event (#7683)
4c4e255 
* use separate type for write ack

* change event-type

Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@jackzampolin @colin-axner @clevinson
Wrap ProtoCodec in interface (#7637)
d5c6011 
* WIP encoding change

* Add test that describes issue

* WIP debugging

* remove extra code

* Update codec/proto_codec.go

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
@fedekunze @mergify @clevinson
ibc: refactor proto files (#7689)
7d0c0be 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@robert-zaremba @mergify @clevinson
simapp: rename MakeEncodingConfig to MakeTestEncodingConfig (#7681)
2e52ba2 
* simapp: rename MakeEncodingConfig to MakeTestEncodingConfig

* Updating the Changelog

+ Adding DEPRECATED attribute.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@colin-axner @mergify @clevinson
Fix Optimistic Channel Handshake bugs (#7678)
cd21a47 
* fix optimistic handshake bugs and add crossing hello test

* fix tests

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@colin-axner @fedekunze
@cwgoes @mergify @clevinson
update core IBC docs (#7560)
564687d 
* update state

* add empty concept fields, update callbacks and messages

* update client creation, update and upgrade section

* add packet lifecycle concepts

* add host and proof section

* add connection handshake section

* add channel handshakes

* state transitions

* self review fixes

* Apply suggestions from code review

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

* apply @fedekunze review suggestions

* packet data section

* Apply suggestions from code review

Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>

* add @cwgoes and @fedekunze review suggestions

* fix typos

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@fedekunze @colin-axner
@mergify @clevinson
ibc: Connection Version changed from string to proto definition (#7644)
48fb155 
* ibc: Version to proto Any

* change version string to struct

* various version fixes

* fix build

* reorder code

* update spec

* rename to ProtoVersionsToExported and ExportedVersionsToProto

Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@anilcse @mergify @clevinson
Rename RegisterGRPCRoutes (#7696)
acc4d46 
* Rename

* Fix missing

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@amaury1093 @fedekunze
@mergify @clevinson
docs: Basic/App-anatomy explains Msg Service by default (#7670)
7f275d5 
* Add msg service

* Add handlers

* Small tweaks

* Remove todo

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@colin-axner @clevinson
Fix panic in context when setting nodeURI (#7699)
9c64301 
* Fix panic in context

Move URI parsing outside of context. WithNodeURI will only set the nodeURI. To set the Client in the context, WithClient must be called.

* add changelog

* add deleted space back
@akhilkumarpilli @anilcse
@jackzampolin @mergify @clevinson
init: Implement ADR 032 typed events (#7564)
9d35a32 
* Add EmitTypedEvent in events

* Add parseTypedEvent method

* Use jsonpb

* Modify unmarshal proto in events

* Add a test for typed events

* Fix reflect  issue in parseTypedEvent

* Modify event tests and add comments

* Add EmitTypedEvents and refactor other methods

* Fix golangci-lint issues

* Update ProtoMarshalJSON params

* Address PR comments

Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@robert-zaremba @mergify @clevinson
msg_service_router: reduce code complexity (#7570)
ca621d3 
* msg_service_router: reduce code complexity

* order imports

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@amaury1093 @robert-zaremba
@blushi @mergify @clevinson
RegisterInterfaces registers service Msg type_urls (#7671)
f33dced 
* Add RegisterMsgServiceDesc

* Refactor newSendTxMsgServiceCmd

* Add test

* Register in all modules

* Remove RegisterMsgServiceDesc from baseapp

* Add explicit error message

* Add comment

* Update comment

* Add test

* Update comment

* Remove duplicate import

* Fix lint

* Forgot vesting

* Fix lint

* Fix test

* Put in types/module

* Put in types/msgservice

* Add comment about panic

* Update baseapp/msg_service_router.go

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update baseapp/msg_service_router.go

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update baseapp/msg_service_router.go

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Add comment

* Add better test

* Update baseapp/msg_service_router.go

Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@AdityaSripal @jackzampolin
@mergify @clevinson
Sort validators like tendermint in HistoricalInfo (#7691)
5a46012 
* sort validators like tendermint

* address comments

* switch ordering in tests

* change sort logic in error case

* don't change test validators array order

Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@clevinson @mergify
Add Deprecation headers for legacy rest endpoints (#7686)
e1c7d02 
* add deprecation headers for legacy rest endpoints

* add deprecation headers for missing tx routes

* rm handler-level deprecation headers

* switch to middleware Route.Use method for setting deprecation Headers

* set deprecation headers using subrouter

* cleanup gofmt

* goimports

* Update client/rest/rest.go

* update deprecation headers to be set on each module individually

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@colin-axner @clevinson
remove proof path from IBC queries (#7725)
c06a2a4 
* remove proof path

* make proto-all with old install

* fix build
@amaury1093 @clevinson
Throw an error on duplicate registration (#7729)
6ae3a94 
* Panic on registering a service twice

* Panic if we register twice

* Fix test

* Fix test

* Add clearer panic message

* Add comment

* Fix test
@jackzampolin @AdityaSripal
@mergify @clevinson
Add function to query ack proofs (#7732)
778c37b 
* Add function to query ack proofs

* Fix compilation issue

Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@zmanian
Copy link
Member

zmanian commented Oct 30, 2020

We should be tracking Tendermint 0.34-rc6 in here.

@clevinson clevinson mentioned this pull request Oct 31, 2020
Closed
9 tasks
@clevinson
Copy link
Contributor Author

Closing as RC's will now be tagged directly off of master following #7738

@clevinson clevinson closed this Nov 2, 2020
@tac0turtle tac0turtle deleted the clevinson/v0.40-rc2-batch-cherrypicks branch February 26, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.