ibc: Connection Version changed from string to proto definition #7644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sdk into fedekunze/ibc-version-any
ibc change connection version string to proto
Codecov Report
@@ Coverage Diff @@
## master #7644 +/- ##
==========================================
- Coverage 54.12% 54.10% -0.02%
==========================================
Files 611 611
Lines 38601 38571 -30
==========================================
- Hits 20892 20869 -23
+ Misses 15576 15574 -2
+ Partials 2133 2128 -5 |
colin-axner
reviewed
Oct 27, 2020
| // proposed version is supported by this chain. If the feature set is | ||
| // empty it verifies that this is allowed for the specified version | ||
| // identifier. | ||
| func (version Version) VerifyProposedVersion(proposedVersion exported.Version) error { |
colin-axner
requested review from
aaronc,
alessio and
alexanderbez
as code owners
colin-axner
changed the title
fedekunze
commented
Oct 27, 2020
There was a problem hiding this comment.
Thanks @colin-axner. The only changes I'd suggest are:
- ProtoToExported -> ProtoVersionToExported
- ExportedToProto -> ExportedVersionToProto
…sdk into colin/connection-version-change
|
ACK. @colin-axner can you approve? |
colin-axner
approved these changes
Oct 27, 2020
clevinson
pushed a commit
that referenced
this pull request
Oct 29, 2020
* ibc: Version to proto Any * change version string to struct * various version fixes * fix build * reorder code * update spec * rename to ProtoVersionsToExported and ExportedVersionsToProto Co-authored-by: Colin Axner <colinaxner@berkeley.edu> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.