Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use InterfaceRegistry as AnyResolver for grpc-gateway #7646

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Oct 23, 2020

#7540 introduced AnyResolver to InterfaceRegistry so that ServiceMsgs can properly be encoded as in proto JSON. This makes sure that is wired up with grpc-gateway for REST and CLI users decoding ServiceMsg tx's. Marking as a backport.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #7646 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7646   +/-   ##
=======================================
  Coverage   54.15%   54.15%           
=======================================
  Files         611      611           
  Lines       38556    38556           
=======================================
  Hits        20881    20881           
  Misses      15543    15543           
  Partials     2132     2132           

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 23, 2020
@mergify mergify bot merged commit 73e7dad into master Oct 23, 2020
@mergify mergify bot deleted the aaronc/grpc-gateway-any-resolver branch October 23, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants