Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sequence checks in solomachine #7586

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

bluele
Copy link
Contributor

@bluele bluele commented Oct 17, 2020

Description

This PR fixes sequence checks in solomachine client.

My understanding of ics-006 is that the verification function must receive the latest sequence. Is that correct?


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #7586 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #7586   +/-   ##
=======================================
  Coverage   54.15%   54.15%           
=======================================
  Files         606      606           
  Lines       38187    38187           
=======================================
  Hits        20680    20680           
  Misses      15410    15410           
  Partials     2097     2097           

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, nice catch!

@colin-axner colin-axner added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 19, 2020
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thanks

@mergify mergify bot merged commit ba2799e into cosmos:master Oct 19, 2020
@bluele bluele deleted the fix-solomachine-sequence-verification branch October 19, 2020 15:27
clevinson pushed a commit that referenced this pull request Oct 29, 2020
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants