-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix gov votes querier to use proposal params for proposal query #7589
Bugfix gov votes querier to use proposal params for proposal query #7589
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7589 +/- ##
==========================================
+ Coverage 50.58% 54.21% +3.63%
==========================================
Files 451 611 +160
Lines 28389 38464 +10075
==========================================
+ Hits 14361 20854 +6493
- Misses 12575 15502 +2927
- Partials 1453 2108 +655 |
x/gov/client/rest/query.go
Outdated
bz, err = clientCtx.LegacyAmino.MarshalJSON(params) | ||
if rest.CheckBadRequestError(w, err) { | ||
return | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move this block in the else
statement as that's the only place we need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah, nice catch. utACK
* bugfix gov votes querier to use votes params * move partially used statement to the proper block Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Description
The gov proposal querier in votes query interface should use
QueryProposalParams
instead ofQueryProposalVotesParams
.closes: #7588
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes