Add GetTx gRPC endpoint #7688
Merged
Add GetTx gRPC endpoint #7688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7688 +/- ##
==========================================
+ Coverage 54.21% 54.31% +0.10%
==========================================
Files 611 610 -1
Lines 38654 38612 -42
==========================================
+ Hits 20956 20972 +16
+ Misses 15564 15503 -61
- Partials 2134 2137 +3 |
aaronc
reviewed
Oct 27, 2020
amaury1093
commented
Oct 27, 2020
amaury1093
commented
Oct 27, 2020
aaronc
reviewed
Oct 27, 2020
fedekunze
reviewed
Oct 27, 2020
amaury1093
commented
Oct 27, 2020
aaronc
requested changes
Oct 28, 2020
clevinson
reviewed
Oct 28, 2020
Co-authored-by: Cory <cjlevinson@gmail.com>
clevinson
reviewed
Oct 29, 2020
4 tasks
alexanderbez
approved these changes
Oct 29, 2020
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
45 tasks
aaronc
approved these changes
Oct 30, 2020
aaronc
reviewed
Oct 30, 2020
| message GetTxResponse { | ||
| // tx is the queried transaction. | ||
| cosmos.tx.v1beta1.Tx tx = 1; | ||
| } |
There was a problem hiding this comment.
Should we be including other TxResponse items like height, data, logs, etc.?
4 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* Add empty TxByHash * Fix search & replace * Renname to GetTx * Make getTx grpc work * Hash as string * Add todo comment * /tx * Make tests pass * Put into function * Add changelog * Fix lint * RegisterTxService in server * Remove comment * Update proto/cosmos/tx/v1beta1/service.proto Co-authored-by: Cory <cjlevinson@gmail.com> * Create new protoCdc * Move tx service to x/auth * Small tweaks * Link gh issue * Fix lint * Update x/auth/tx/service.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Cory <cjlevinson@gmail.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: SaReN <sahithnarahari@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #7355
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes