Remove ClientType func and update consensus state path #7573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
added
x/ibc
Type: Code Hygiene
colin-axner
requested review from
aaronc,
alessio and
alexanderbez
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7573 +/- ##
==========================================
- Coverage 54.30% 54.16% -0.15%
==========================================
Files 454 606 +152
Lines 30448 38164 +7716
==========================================
+ Hits 16536 20671 +4135
- Misses 12287 15398 +3111
- Partials 1625 2095 +470 |
fedekunze
approved these changes
Oct 16, 2020
colin-axner
added
the
A:automerge
clevinson
pushed a commit
that referenced
this pull request
Oct 29, 2020
* update paths and remove unused func * fix bug Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Christopher Goes <cwgoes@pluranimity.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
45 tasks
odeke-em
reviewed
Feb 6, 2021
| // ConsensusStatePath takes an Identifier and returns a Path under which to | ||
| // store the consensus state of a client. | ||
| func ConsensusStatePath(height exported.Height) string { | ||
| return fmt.Sprintf("consensusState/%s", height) | ||
| return fmt.Sprintf("%s/%s", KeyConsensusStatesPrefix, height) |
There was a problem hiding this comment.
There is a bug here, and surprised it wasn't flagged by the linters.
There was a problem hiding this comment.
not sure I follow. What is the bug?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets the consensus state path to match the ICS spec recommendations. Removes unused ClientType func.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes