IBC: panic on GetSignBytes and remove SubModuleCdc #7645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
aaronc,
alessio and
alexanderbez
as code owners
colin-axner
changed the title
colin-axner
requested review from
cwgoes,
fedekunze,
clevinson and
AdityaSripal
Codecov Report
@@ Coverage Diff @@
## master #7645 +/- ##
==========================================
- Coverage 54.15% 54.14% -0.02%
==========================================
Files 611 611
Lines 38556 38556
==========================================
- Hits 20881 20877 -4
- Misses 15543 15547 +4
Partials 2132 2132 |
alexanderbez
approved these changes
Oct 23, 2020
fedekunze
reviewed
Oct 23, 2020
| func (msg MsgTransfer) GetSignBytes() []byte { | ||
| return sdk.MustSortJSON(ModuleCdc.MustMarshalJSON(&msg)) | ||
| panic("IBC messages do not support amino") |
There was a problem hiding this comment.
q: why not return nil bytes? the tx will fail regardless
There was a problem hiding this comment.
What if someone tries to use this function in an application module? Returning nil could be a silent failure. Also going off this comment
There was a problem hiding this comment.
I guess the logic for panic is that it will clearly communicate why it's failing whereas in Jack's issue he thought it should work.
| func (msg MsgCreateClient) GetSignBytes() []byte { | ||
| return sdk.MustSortJSON(SubModuleCdc.MustMarshalJSON(&msg)) | ||
| panic("IBC messages do not support amino") |
fedekunze
approved these changes
Oct 23, 2020
fedekunze
added
the
A:automerge
clevinson
pushed a commit
that referenced
this pull request
Oct 29, 2020
* panic on GetSignBytes and remove SubModuleCdc where possible * fix build Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #7638
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes