Fix IBC Query cmds #7648
Merged
Fix IBC Query cmds #7648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
aaronc,
alessio and
alexanderbez
as code owners
colin-axner
commented
Oct 23, 2020
| // Issue: https://github.com/cosmos/cosmos-sdk/issues/6567 | ||
| func QueryTendermintProof(clientCtx client.Context, key []byte) ([]byte, []byte, clienttypes.Height, error) { | ||
| height := clientCtx.Height | ||
|
|
||
| // ABCI queries at height less than or equal to 2 are not supported. | ||
| // Base app does not support queries for height less than or equal to 1. | ||
| // Therefore, a query at height 2 would be equivalent to a query at height 3 | ||
| if clientCtx.Height <= 2 { | ||
| if height != 0 && height <= 2 { |
There was a problem hiding this comment.
turns out, somewhere down the line, a height of 0 is interpreted as latest height
There was a problem hiding this comment.
can you update the comment too?
There was a problem hiding this comment.
updated, I left the error message as is
colin-axner
requested review from
cwgoes,
fedekunze,
AdityaSripal and
jackzampolin
Codecov Report
@@ Coverage Diff @@
## master #7648 +/- ##
==========================================
- Coverage 54.20% 54.15% -0.05%
==========================================
Files 454 611 +157
Lines 30638 38556 +7918
==========================================
+ Hits 16606 20881 +4275
- Misses 12392 15543 +3151
- Partials 1640 2132 +492 |
fedekunze
approved these changes
Oct 23, 2020
| // Issue: https://github.com/cosmos/cosmos-sdk/issues/6567 | ||
| func QueryTendermintProof(clientCtx client.Context, key []byte) ([]byte, []byte, clienttypes.Height, error) { | ||
| height := clientCtx.Height | ||
|
|
||
| // ABCI queries at height less than or equal to 2 are not supported. | ||
| // Base app does not support queries for height less than or equal to 1. | ||
| // Therefore, a query at height 2 would be equivalent to a query at height 3 | ||
| if clientCtx.Height <= 2 { | ||
| if height != 0 && height <= 2 { |
There was a problem hiding this comment.
can you update the comment too?
…into colin/fix-q-cmds-7583
colin-axner
added
the
A:automerge
clevinson
pushed a commit
that referenced
this pull request
Oct 29, 2020
* fix query * update comment
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested:
closes: #7583
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes