Throw an error on duplicate registration #7729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
commented
Oct 29, 2020
| // we panic). | ||
| foundImplType, found := imap[typeURL] | ||
| if found && foundImplType != implType { | ||
| panic( |
There was a problem hiding this comment.
sorry Robert, it's hard not to panic here. I think we need to change the signature of RegisterInterfaces everywhere on AppModuleBasic, if we don't want to panic.
Codecov Report
@@ Coverage Diff @@
## master #7729 +/- ##
==========================================
+ Coverage 54.17% 54.21% +0.03%
==========================================
Files 611 611
Lines 38624 38654 +30
==========================================
+ Hits 20926 20956 +30
Misses 15564 15564
Partials 2134 2134 |
amaury1093
requested review from
aaronc,
alessio and
alexanderbez
as code owners
aaronc
reviewed
Oct 29, 2020
|
I added clearer messages in the panics, feel free to suggest some better wording. |
amaury1093
added
the
A:automerge
aaronc
approved these changes
Oct 29, 2020
clevinson
pushed a commit
that referenced
this pull request
Oct 29, 2020
* Panic on registering a service twice * Panic if we register twice * Fix test * Fix test * Add clearer panic message * Add comment * Fix test
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #7679
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes