Fix Optimistic Channel Handshake bugs #7678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
aaronc,
alessio and
alexanderbez
as code owners
|
More rigorous optimistic handshake testing can be added with #7603 ensuring packets can be safely sent between OpenInit and OpenTry calls |
Codecov Report
@@ Coverage Diff @@
## master #7678 +/- ##
==========================================
- Coverage 54.15% 54.12% -0.03%
==========================================
Files 611 611
Lines 38566 38601 +35
==========================================
+ Hits 20884 20892 +8
- Misses 15550 15576 +26
- Partials 2132 2133 +1 |
…-sdk into colin/7605-crossing-hellos
fedekunze
added
the
A:automerge
clevinson
pushed a commit
that referenced
this pull request
Oct 29, 2020
* fix optimistic handshake bugs and add crossing hello test * fix tests Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
45 tasks
cwgoes
reviewed
Nov 2, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #7605
closes: #7606
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes