Sort validators like tendermint in HistoricalInfo #7691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaSripal
requested review from
aaronc,
alessio and
alexanderbez
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7691 +/- ##
==========================================
+ Coverage 54.13% 54.14% +0.01%
==========================================
Files 611 611
Lines 38639 38648 +9
==========================================
+ Hits 20917 20926 +9
+ Misses 15590 15588 -2
- Partials 2132 2134 +2 |
|
@AdityaSripal take a peek here too. Might want to make sure you can take that output and use |
fedekunze
reviewed
Oct 27, 2020
colin-axner
reviewed
Oct 28, 2020
colin-axner
reviewed
Oct 28, 2020
colin-axner
reviewed
Oct 28, 2020
cwgoes
reviewed
Oct 28, 2020
alexanderbez
approved these changes
Oct 28, 2020
|
@AdityaSripal it looks like gRPC tests are failing |
fedekunze
approved these changes
Oct 29, 2020
AdityaSripal
added
the
A:automerge
clevinson
pushed a commit
that referenced
this pull request
Oct 29, 2020
* sort validators like tendermint * address comments * switch ordering in tests * change sort logic in error case * don't change test validators array order Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #7676
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes