Fix fetch txs by height on legacy REST endpoint #7730
Conversation
amaury1093
force-pushed
the
am-7721-amino-height
branch
from
04b3a0b
to
fe36f9c
Compare
| return | ||
| } | ||
|
|
||
| if output.Empty() { | ||
| rest.WriteErrorResponse(w, http.StatusNotFound, fmt.Sprintf("no transaction found with hash %s", hashHexStr)) | ||
| } | ||
|
|
||
| rest.PostProcessResponseBare(w, clientCtx, stdTx) | ||
| rest.PostProcessResponseBare(w, clientCtx, output) |
There was a problem hiding this comment.
This happens on the query tx by hash endpoint. On master: we output a StdTx. In this PR, I changed to output a TxResponse.
This is a breaking change compared to master, but it's actually the same output as 0.39. I think TxResponse is better here.
x/auth/client/rest/rest_test.go
Outdated
| s.Require().True(strings.Contains(string(txJSON), stdTx.Memo)) | ||
|
|
||
| // We now fetch the tx on `/txs` route, filtering by `height` | ||
| txJSON, err = rest.GetRequest(fmt.Sprintf("%s/txs?height=%d", val0.APIAddress, txRes.Height)) |
There was a problem hiding this comment.
Anyone knows why we can have both the ?height= and the ?tx.height= query params?
?tx.height (posted by Zaki initially) now works correctly. However, ?height returns 0 result, but maybe it means something else?
Test fails because I'm not sure what it's actually supposed to do.
There was a problem hiding this comment.
I removed testing ?height for now. I am not sure if ?height=n is supposed to:
- set the clientCtx height to
n - query events with attribute
height=n - or both
amaury1093
requested review from
aaronc,
alessio and
alexanderbez
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7730 +/- ##
==========================================
+ Coverage 54.31% 54.34% +0.03%
==========================================
Files 610 610
Lines 38621 38627 +6
==========================================
+ Hits 20976 20992 +16
+ Misses 15508 15492 -16
- Partials 2137 2143 +6 |
amaury1093
added
the
A:automerge
Description
closes #7721
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes