remove proof path from IBC queries #7725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
aaronc,
alessio and
alexanderbez
as code owners
colin-axner
added
the
A:automerge
Codecov Report
@@ Coverage Diff @@
## master #7725 +/- ##
==========================================
+ Coverage 54.14% 54.17% +0.03%
==========================================
Files 611 611
Lines 38648 38624 -24
==========================================
Hits 20926 20926
+ Misses 15588 15564 -24
Partials 2134 2134 |
AdityaSripal
approved these changes
Oct 29, 2020
There was a problem hiding this comment.
ACK, path shouldn't be submitted by clients so makes sense to remove it from query responses. Thoughts @cwgoes
fedekunze
approved these changes
Oct 29, 2020
Yes, this seems correct to me, it's not up to the choice of the client. |
clevinson
pushed a commit
that referenced
this pull request
Oct 29, 2020
* remove proof path * make proto-all with old install * fix build
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #7723
closes: #7614
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes