Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TxsByEvent gRPC endpoint #7842

Merged
merged 27 commits into from
Nov 12, 2020
Merged

Add TxsByEvent gRPC endpoint #7842

merged 27 commits into from
Nov 12, 2020

Conversation

aleem1314
Copy link
Contributor

ref: #7355

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Nov 6, 2020 •
edited
Loading

Codecov Report

Merging #7842 (cad1dd4) into master (c8afb2c) will increase coverage by 0.01%.
The diff coverage is 66.15%.

@@            Coverage Diff             @@
##           master    #7842      +/-   ##
==========================================
+ Coverage   54.17%   54.18%   +0.01%     
==========================================
  Files         612      612              
  Lines       38928    38989      +61     
==========================================
+ Hits        21089    21126      +37     
- Misses      15685    15696      +11     
- Partials     2154     2167      +13

@aleem1314 aleem1314 marked this pull request as ready for review November 6, 2020 16:27
anilcse
anilcse approved these changes Nov 9, 2020
View reviewed changes
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

x/auth/tx/service.go Outdated Show resolved Hide resolved
@aleem1314 aleem1314 requested a review from amaury1093 November 9, 2020 14:22
amaury1093
amaury1093 reviewed Nov 9, 2020
View reviewed changes
proto/cosmos/tx/v1beta1/service.proto Outdated Show resolved Hide resolved
proto/cosmos/tx/v1beta1/service.proto Outdated Show resolved Hide resolved
x/auth/tx/service.go Outdated Show resolved Hide resolved
x/auth/tx/service_test.go Outdated Show resolved Hide resolved
x/auth/tx/service.go Show resolved Hide resolved
proto/cosmos/tx/v1beta1/service.proto Outdated Show resolved Hide resolved
@amaury1093 amaury1093 mentioned this pull request Nov 9, 2020
Closed
alexanderbez
alexanderbez suggested changes Nov 10, 2020
View reviewed changes
proto/cosmos/tx/v1beta1/service.proto Outdated Show resolved Hide resolved
x/auth/tx/service.go Outdated Show resolved Hide resolved
x/auth/tx/service.go Show resolved Hide resolved
x/auth/tx/service.go Outdated Show resolved Hide resolved
x/auth/tx/service.go Outdated Show resolved Hide resolved
x/auth/tx/service.go Outdated Show resolved Hide resolved
x/auth/tx/service.go Outdated Show resolved Hide resolved
fedekunze
fedekunze suggested changes Nov 11, 2020
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 1 minor comment (you'll need to run make proto-all as well afterward)

proto/cosmos/tx/v1beta1/service.proto Outdated Show resolved Hide resolved
@fedekunze fedekunze added C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. A:automerge Automatically merge PR once all prerequisites pass. labels Nov 11, 2020
fedekunze
fedekunze approved these changes Nov 11, 2020
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

alexanderbez
alexanderbez suggested changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a bit of minor cosmetic feedback.

proto/cosmos/tx/v1beta1/service.proto Outdated Show resolved Hide resolved
x/auth/tx/service.go Show resolved Hide resolved
alexanderbez
alexanderbez approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mergify mergify bot merged commit f3e4964 into master Nov 12, 2020
@mergify mergify bot deleted the aleem/7355-grpc-endpoints branch November 12, 2020 14:22
@clevinson clevinson mentioned this pull request Nov 24, 2020
Closed
4 tasks
@clevinson clevinson mentioned this pull request Dec 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaury1093 amaury1093 amaury1093 left review comments

@fedekunze fedekunze fedekunze approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alessio alessio Awaiting requested review from alessio

@anilcse anilcse Awaiting requested review from anilcse

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C: gRPC Issues and PRs related to the gRPC service and HTTP gateway.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aleem1314 @amaury1093 @anilcse @alexanderbez @fedekunze