types/tx: add missing fields to GetTxResponse #7867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
requested review from
aaronc,
alessio and
alexanderbez
as code owners
|
Hey Fede, have a look at #7842 (comment). I was proposing to have a struct to represent this (similar to abci's TxResponse). This struct can be re-used in TxsByEvent. |
Codecov Report
@@ Coverage Diff @@
## master #7867 +/- ##
=======================================
Coverage 54.19% 54.20%
=======================================
Files 610 610
Lines 38811 38815 +4
=======================================
+ Hits 21035 21039 +4
Misses 15621 15621
Partials 2155 2155 |
|
@amaurymartiny makes sense. Should I close this PR then? |
|
yeah, i'd say so. Would love your ideas on: #7842 (comment). i.e. what fields to put in that struct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds tx Height, Index and Proof to the response fields